Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast own address to Individial address when specified within xknx.yaml #538

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

Julius2342
Copy link
Collaborator

@Julius2342 Julius2342 commented Dec 20, 2020

Description

Specifying own_address within xknx.yaml broke during a recent refactoring. (Looks like I'm the only person using this :-) ).

This led to a TypeError when comparing Telegrams.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 94.773% when pulling 8ff9853 on Julius2342:fix-xknx-yaml-individual-address into 30720c7 on XKNX:master.

@farmio
Copy link
Member

farmio commented Dec 21, 2020

Oops 😬
Thank you!

@farmio farmio merged commit 542b678 into XKNX:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants