-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
157 missing translations warning #571
Commits on Nov 19, 2021
-
add: warning for missing translations in the survey sheet
- added tests have a couple of todo's to follow up - will also need to add: - test cases for happy path and other translatable columns - the same sort of check for the translatable choices sheet columns - also added some obvious type annotations and moved repeated usages of "default" for the default language to the constants module.
Configuration menu - View commit details
-
Copy full SHA for e572ea4 - Browse repository at this point
Copy the full SHA e572ea4View commit details
Commits on Nov 22, 2021
-
add: happy path tests for establishing translations behaviour
- in the tests in the prior commit it was becoming difficult to discern the correct / normal behaviour is for various translation scenarios - includes numerous todo's for suspect behaviour that may be bugs - added guidance_hint to translatable columns list
Configuration menu - View commit details
-
Copy full SHA for bd7cf43 - Browse repository at this point
Copy the full SHA bd7cf43View commit details -
Configuration menu - View commit details
-
Copy full SHA for b796c37 - Browse repository at this point
Copy the full SHA b796c37View commit details -
Configuration menu - View commit details
-
Copy full SHA for ecc63f6 - Browse repository at this point
Copy the full SHA ecc63f6View commit details
Commits on Nov 23, 2021
-
add: test cases / handling for issue 157 case and media cols, tidy up
- simplified representation of issue 157 source case where label + hint are in French, with a default lang image column, and no default set. - media columns were not being detected correctly since the survey_sheet object nests audio, image and video in a "media" dict. - updated constants list with comment on other possible translatable columns in case pyxform supports them in future. - general tidy up of test xpaths and usages of them, such as to remove combination/shortcut xpaths, specify absence of ref or form attributes where relevant, condense guidance/audio/image/video xpaths. - remove duplicate test todo's for the same issue in a similar context.
Configuration menu - View commit details
-
Copy full SHA for 8ae5482 - Browse repository at this point
Copy the full SHA 8ae5482View commit details
Commits on Nov 24, 2021
-
add: test cases for choices sheet translations, organise tests
- moved TranslationTest.test_missing_media_itext to TestTranslations - moved new TranslationTest tests to TestTranslationsSurvey - added TestTranslationsChoices - similar to survey tests, added to clarify existing behaviour - includes some initial cases, for with/out a lang and choice_filter - some overlap with module test_secondary_instance_translations.py which should be resolved once these tests are complete. - added a XPathHelper class to try and make the choices tests more legible and easier to document, vs. the constants used for survey tests. Could adapt / extend helper for survey tests as well.
Configuration menu - View commit details
-
Copy full SHA for 3c69a6f - Browse repository at this point
Copy the full SHA 3c69a6fView commit details
Commits on Nov 26, 2021
-
chg: refactor remaining translation tests to use XPathHelper, add docs
- Update TestTranslations and TestTranslationsSurvey that were using string constants to use XPathHelper so that the assertions being made are easier to follow. - Add XPathHelper method docstrings to describe what they assert.
Configuration menu - View commit details
-
Copy full SHA for 1763349 - Browse repository at this point
Copy the full SHA 1763349View commit details -
add: show the XPath and the XForm when an assert_xpath_count fails
- Previously just showing the XForm made it a mystery which of the (potentially many) XPath expressions failed to match.
Configuration menu - View commit details
-
Copy full SHA for 83ef307 - Browse repository at this point
Copy the full SHA 83ef307View commit details -
add: tests / handling for constraintMsg and requiredMsg missing langs
- Add to existing warning for missing translations where the affected columns are constraint_message or required_message - Due to a difference in the internally used name and supported external aliases, the TRANSLATABLE_SURVEY_COLUMNS object is now a dict and moved to aliases.py so it is closer to the existing aliases dicts to help keep them in sync.
Configuration menu - View commit details
-
Copy full SHA for 37ba6ee - Browse repository at this point
Copy the full SHA 37ba6eeView commit details
Commits on Nov 30, 2021
-
fix: remove leftover debug=True parameter, correct docstring typo
- debug=True causes the XForm and other test info to be printed out but this shouldn't be present on committed tests. - If warnings__* parameters are misspelled then they don't do anything.
Configuration menu - View commit details
-
Copy full SHA for dfeca3e - Browse repository at this point
Copy the full SHA dfeca3eView commit details -
add: check for missing translations in choices sheet
- checks columns shown in aliases.py - check done alongside survey check so there's just warning message about missing translations - add choices warning test cases for same set of scenarios as for survey - update existing survey tests to use warnings__contains or not_contains instead of passing in list and doing assertIn / assertNotIn
Configuration menu - View commit details
-
Copy full SHA for 90a2895 - Browse repository at this point
Copy the full SHA 90a2895View commit details -
chg: move missing_translations_check into validator subpackage
- the three related functions for this check are parts of a validation, and they otherwise clutter up xls2json.py a bit. - may make sense to move other xls2json checks into the same package so it's clearer what validations pyxform does.
Configuration menu - View commit details
-
Copy full SHA for d3e6f82 - Browse repository at this point
Copy the full SHA d3e6f82View commit details -
add: test case for xlsform with missing translations in survey + choices
- combination of existing tests with same name pattern but in one test case that has both warning and no-warning assertions.
Configuration menu - View commit details
-
Copy full SHA for ffd073d - Browse repository at this point
Copy the full SHA ffd073dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06fe4c0 - Browse repository at this point
Copy the full SHA 06fe4c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6626782 - Browse repository at this point
Copy the full SHA 6626782View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad6830d - Browse repository at this point
Copy the full SHA ad6830dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99b0eae - Browse repository at this point
Copy the full SHA 99b0eaeView commit details
Commits on Dec 6, 2021
-
add: performance test for missing translations check (default skipped)
- to check whether the missing translation check incurs a reasonable time cost, considering that it traverses the full XLSForm dict available in xls2json rather than earlier in the pipeline to just check sheet headers. It seems there is very little difference for a giant form with 500 questions and 2 choices per question.
Configuration menu - View commit details
-
Copy full SHA for 978c307 - Browse repository at this point
Copy the full SHA 978c307View commit details -
Merge branch 'master' into pyxform-157
# Conflicts: # pyxform/xls2json.py
Configuration menu - View commit details
-
Copy full SHA for f1babeb - Browse repository at this point
Copy the full SHA f1babebView commit details
Commits on Jan 21, 2022
-
fix: performance improvements for large forms
- missing translations check can still work while only looking at first row, which is a little faster and still passes the tests. - while profiling, found an inefficient unique check in section.py. The benefit is only apparent with forms >1000 questions, but it is significant: q=5000 28s vs. 11s, q=10000 103s vs. 21s.
Configuration menu - View commit details
-
Copy full SHA for eb6f0fe - Browse repository at this point
Copy the full SHA eb6f0feView commit details
Commits on Jan 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6e9adb6 - Browse repository at this point
Copy the full SHA 6e9adb6View commit details
Commits on Feb 7, 2022
-
chg: remove default_language from check criteria, update warning format
- default_language setting shouldn't influence the warning since the underlying issue is missing languages, and the setting just happens to be a way around one of the problems that causes. - updated the warning format to be one line per lang/sheet, with column names listed in the line. - includes corresponding test changes for the above, and re-configures how the check func processes data to better match the warning format.
Configuration menu - View commit details
-
Copy full SHA for ed1701c - Browse repository at this point
Copy the full SHA ed1701cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c12e4e - Browse repository at this point
Copy the full SHA 8c12e4eView commit details