New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/remove wallet from pool if low balance #97

Merged

abhidtu2014 merged 28 commits into main from feat/remove-wallet-from-pool-if-low-balance

Sep 21, 2023

Contributor

abhidtu2014 commented Aug 31, 2023 •

edited

Loading

Add functionality for removing/adding back the wallet from the pool of the resources
We will be removing the wallet from the pool based on the minThreshold set from the rebalance config
Fix minor issues
Add test cases based on ganache, fixed existing test cases
Adds New wallet interface that will be used by wallet-middleware in relayer-engine-middleware

abhidtu2014 requested a review from a team

August 31, 2023 12:55

abhidtu2014 commented

View reviewed changes

src/chain-wallet-manager.ts Show resolved Hide resolved


          Add functionality for removing/adding back the wallet from the pool|T…

2c56f24

…ests

abhidtu2014 force-pushed the feat/remove-wallet-from-pool-if-low-balance branch from 6576977 to 2c56f24 Compare

August 31, 2023 14:30


          Fix test GH worflow

4515f86

mat1asm reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

mat1asm reviewed

View reviewed changes

test/wallet-manager.test.ts Show resolved Hide resolved

abhidtu2014 added 4 commits

September 3, 2023 20:52


          Add getWalletBalance on wallet interface

b8a1d20


          Expose wallet execute options

b414724


          Add create signed method in walletToolBox

eef1068


          Remove privateKey from walletInterface exposed through withWallet

8d75f2d

abhidtu2014 requested review from iturricf, mat1asm and solanoepalacio

September 4, 2023 12:14


          remove untyped provider|fix type issue

0808f88

mat1asm reviewed

View reviewed changes

package.json Outdated Show resolved Hide resolved

mat1asm reviewed

View reviewed changes

package.json Outdated Show resolved Hide resolved

mat1asm reviewed

View reviewed changes

src/wallets/base-wallet.ts Outdated Show resolved Hide resolved

mat1asm reviewed

View reviewed changes

src/wallets/evm/index.ts Outdated Show resolved Hide resolved

mat1asm reviewed

View reviewed changes

src/wallets/wallet-pool.ts Outdated Show resolved Hide resolved

mat1asm reviewed

View reviewed changes

test/wallet-manager.test.ts Outdated Show resolved Hide resolved

abhidtu2014 added 6 commits

September 6, 2023 16:37


          Resolve PR review comments

208f1a3


          Rename test file

ef078a6


          Fix timeout test utility to clear the timeout

9bf8b79


          Add expected behaviour in test case for understanding

4e94bd8


          PR review: Use genric type in base-wallet class

6cbeabb


          Merge branch 'main' of github.com:XLabs/wallet-monitor into feat/remo…

983e9ba

…ve-wallet-from-pool-if-low-balance

abhidtu2014 requested a review from mat1asm

September 7, 2023 14:15

abhidtu2014 added 2 commits

September 11, 2023 12:12


          Adding generic types to wallet-manager interface

8b07acf


          Expose Providers and Wallets as types

acb9077

solanoepalacio reviewed

View reviewed changes

src/wallets/base-wallet.ts Outdated Show resolved Hide resolved

solanoepalacio reviewed

View reviewed changes

src/wallets/sui/index.ts Show resolved Hide resolved

solanoepalacio reviewed

View reviewed changes

src/wallets/sui/index.ts Outdated Show resolved Hide resolved

Collaborator

solanoepalacio commented Sep 14, 2023

If I understand correctly there are two features on this PR:

removing the wallet from the pool if balance is not enough
changing the wallet interface to support the new wallet middleware
I know this probably happened because of the mention to the balance on the wallet-interface ticket, he... we'll do better at ticket refinement :)
In the mean time... I think we would be ok marking the remove wallet from pool if... ticket to ready to release or done

solanoepalacio reviewed

View reviewed changes

src/chain-wallet-manager.ts Outdated Show resolved Hide resolved


          Resolve PR comments

488c6d2

abhidtu2014 force-pushed the feat/remove-wallet-from-pool-if-low-balance branch from a88c228 to 488c6d2 Compare

September 14, 2023 12:13

abhidtu2014 added 3 commits

September 18, 2023 16:57


          PR review: Update wallet interface

d1cf2ff


          Bump version


          Add getGasPrice to wallet int for backward compatability

da0fe1a

solanoepalacio reviewed

View reviewed changes

src/chain-wallet-manager.ts Outdated Show resolved Hide resolved

solanoepalacio reviewed

View reviewed changes

src/chain-wallet-manager.ts Outdated Show resolved Hide resolved

solanoepalacio reviewed

View reviewed changes

src/chain-wallet-manager.ts Outdated Show resolved Hide resolved

solanoepalacio reviewed

View reviewed changes

src/wallets/wallet-pool.ts Show resolved Hide resolved

solanoepalacio reviewed

View reviewed changes

src/wallets/base-wallet.ts Show resolved Hide resolved


          Add getGasPrice to walletInterface | Todo for solana and sui

dff95fe

abhidtu2014 requested a review from solanoepalacio

September 20, 2023 11:58

scnale reviewed

View reviewed changes

src/chain-wallet-manager.ts Outdated Show resolved Hide resolved

abhidtu2014 added 3 commits

September 20, 2023 18:45


          Remove unwanted wormhole-sdk dependency

83d99a2


          Expose walletToolbox directly in favor of simplicity

c329dc0


          bump beta version with latest changes

b36c1fe

solanoepalacio reviewed

View reviewed changes

package.json Outdated Show resolved Hide resolved

solanoepalacio reviewed

View reviewed changes

test/utilities/wallet.ts

+              export const ETH_ADDR = "0xFa6E597ca1c7E72838c850d1268dDf618D444712";
+              export const ETH_ADDR_2 = "0x0EaC31cB932229D0Dcc628f89894012b7827481c";
+              export const checkIfWalletIsReady = async (

Collaborator

solanoepalacio Sep 21, 2023

I love that you made this a utility right away 🖤
Seems the right abstraction

solanoepalacio approved these changes

View reviewed changes

solanoepalacio approved these changes

View reviewed changes

mat1asm reviewed

View reviewed changes

src/wallets/solana/index.ts Show resolved Hide resolved

abhidtu2014 added 2 commits

September 21, 2023 18:31


          Resolve PR review comments

529d6bf


          bump version

b70efac

abhidtu2014 merged commit c7ddab1 into main

1 check passed

abhidtu2014 deleted the feat/remove-wallet-from-pool-if-low-balance branch

September 21, 2023 13:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet