Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more possible extensions #621

Closed
wants to merge 1 commit into from
Closed

add more possible extensions #621

wants to merge 1 commit into from

Conversation

ggoffy
Copy link
Contributor

@ggoffy ggoffy commented Jan 17, 2019

No description provided.

@geekwright
Copy link
Contributor

There are potential backward compatibility breaks to add these new extensions -- such as previously invisible things showing up. In general the getImgListAsArray() method is used to supply filenames that can be used directly in an img tag. While tiff is very useful in some situations, it has virtually no support. While better supported, BMP's are generally regarded as a poor choice for web graphics. For now we will stick with the three main types.

To make it easier to produce custom lists using a simple array of file extensions, #623 introduces a new method, XoopsList::getFileListByExtension(). This eliminates the awkward regex maintenance. too.

@geekwright geekwright closed this Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants