Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow to check new libXRPL version #1433

Merged
merged 3 commits into from
May 29, 2024

Conversation

godexsoft
Copy link
Collaborator

This is the Clio side of things for XRPLF/rippled#5028

The new flow is triggered remotely from rippled's CI once a new version of libXRPL is proposed.
If either building or test are broken an issue for investigation is automatically created.

@godexsoft godexsoft mentioned this pull request May 28, 2024
2 tasks
.githooks/update-libxrpl-version Outdated Show resolved Hide resolved
.github/workflows/check_libxrpl.yml Show resolved Hide resolved
@godexsoft godexsoft requested a review from kuznetsss May 29, 2024 10:45
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.88%. Comparing base (da5bf5c) to head (3f81f24).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1433   +/-   ##
========================================
  Coverage    67.88%   67.88%           
========================================
  Files          232      232           
  Lines         9335     9335           
  Branches      5210     5210           
========================================
  Hits          6337     6337           
  Misses        1638     1638           
  Partials      1360     1360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@godexsoft godexsoft merged commit 66e8a65 into XRPLF:develop May 29, 2024
16 checks passed
kuznetsss pushed a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants