-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deletion script will not OOM #1679
fix: deletion script will not OOM #1679
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1679 +/- ##
===========================================
+ Coverage 69.92% 70.36% +0.44%
===========================================
Files 260 266 +6
Lines 9976 10182 +206
Branches 5500 5618 +118
===========================================
+ Hits 6976 7165 +189
+ Misses 1586 1542 -44
- Partials 1414 1475 +61 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks good to me.
But the bookmark can be put into a class.
The workerCount seems incorrec. If I understand correctly, the number of goroutine running concurrently is workerCount*workerCount now.
Maybe we can pack the continue.txt logic all in one class like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ~ LGTM
fixes #1676 and #1678