Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #4108

Closed
wants to merge 2 commits into from
Closed

Update README.md #4108

wants to merge 2 commits into from

Conversation

wojake
Copy link
Collaborator

@wojake wojake commented Feb 24, 2022

Add social media account (Ripple) & Community chatroom (maintained by RippleX)

High Level Overview of Change

Context of Change

Added rippled maintainer's twitter account and added the community chatroom (maintained by RippleX), adding the community chatroom would definitely help connect developers together.
This would allow devs and rippled hosts to:

  • ask technical questions

  • suggest changes to be made

  • discuss about everything and anything related to rippled/XRPL

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • Refactor (non-breaking change that only restructures code)

  • Tests (You added tests for code that already exists, or your new feature included in this PR)

  • Documentation Updates

  • Release

Add social media account (Ripple) & Community chatroom (maintained by RippleX)
Copy link
Contributor

@nbougalis nbougalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veto 🛑

I have a couple of issues with this commit.

First is the inclusion of Ripple's Twitter account. Ripple's social media account is not relevant to this project, and a link to it does not belong in the README file for this project.

Second, I'm not sure it's a good idea to list the Discord channel so prominently. Perhaps you can add a new section, near the bottom of the file which includes links to fora or chat media?

@wojake
Copy link
Collaborator Author

wojake commented Feb 27, 2022

On second thought, I agree with you but what if we also include "Setup and Installation" & "Source Documentation" to the list rather then putting them to the 'See Also' section? The discord link will stay and Ripple's social media account will be delisted.

@legleux
Copy link
Collaborator

legleux commented Feb 28, 2022

Second, I'm not sure it's a good idea to list the Discord channel so prominently. Perhaps you can add a new section, near the bottom of the file which includes links to fora or chat media?

I'm going to agree that this shouldn't be the #1 thing displayed on the README.
If you could also make a new link that isn't linked with your user. Here's one: http://xrpldevs.org/

Lines 50-51 can be removed also:

Some of the directories under src are external repositories included using git-subtree. See those directories' README files for more details.

@wojake wojake closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants