Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeliverMax to more JSONRPC tests #4826

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Add DeliverMax to more JSONRPC tests #4826

merged 3 commits into from
Jan 17, 2024

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Nov 21, 2023

High Level Overview of Change

Context of Change

Minor change in unit tests to improve testing scope

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@Bronek Bronek marked this pull request as ready for review November 21, 2023 16:36
@seelabs seelabs self-requested a review November 21, 2023 17:41
@intelliot intelliot added this to the 2024 release milestone Nov 27, 2023
@Bronek Bronek force-pushed the feature/enhance_test_JSONRPC branch from a57b3a1 to 73a5223 Compare December 4, 2023 14:51
@Bronek Bronek force-pushed the feature/enhance_test_JSONRPC branch from 73a5223 to 1d3c37c Compare December 7, 2023 11:33
scottschurr
scottschurr approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

@intelliot intelliot modified the milestones: 2.1.0 (Feb 2024), 2.0.1 Jan 10, 2024
@intelliot intelliot added the Perf impact not expected Change is not expected to improve nor harm performance. label Jan 10, 2024
@intelliot
Copy link
Collaborator

note: only touches a test file. should be low-risk to include in any release.

@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jan 10, 2024
@intelliot intelliot merged commit 6ac2b70 into XRPLF:develop Jan 17, 2024
16 checks passed
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
e4f6a89 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
f6e98cc 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
dc36f1d 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
d26e44c 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
02a1708 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
4ec451c 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
ed645f6 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
c86fae6 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
7f862f5 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
d1df32f 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
2c9e78d 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
fdf879f 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
6b60ff2 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
d1b7310 
Minor change in unit tests to improve testing scope.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 17, 2024
@Bronek @ximinez
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
9eb360a 
Minor change in unit tests to improve testing scope.
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
@Bronek @sophiax851
test: add DeliverMax to more JSONRPC tests (XRPLF#4826)
000b3d9 
Minor change in unit tests to improve testing scope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottschurr scottschurr scottschurr approved these changes

@HowardHinnant HowardHinnant HowardHinnant approved these changes

@seelabs seelabs seelabs approved these changes

Assignees
No one assigned
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Perf impact not expected Change is not expected to improve nor harm performance.
Projects
Core Ledger
Archived in project
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
6 participants
@Bronek @intelliot @seelabs @HowardHinnant @scottschurr @ximinez