Update help message about unit test-suite pattern matching #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new unit test name pattern matching rule
ckeshava
changed the title
|
@ximinez could you review this PR? |
ximinez
requested changes
Jan 16, 2024
ximinez
approved these changes
Jan 17, 2024
ximinez
approved these changes
Jan 19, 2024
|
note: this is essentially documentation, so would be fine to include in 2.0.1 |
intelliot
added
the
Passed
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
…LF#4846) Update the "rippled --help" message for the "-u" parameter. This documents the unit test name pattern matching rule implemented by XRPLF#4634. Fix XRPLF#4800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR updates the help message to reflect the latest state of the codebase. It also renames the unit tests to be more descriptive.
Fix #4800
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
No changes to the API output.
This PR documents the changes already implemented by #4634 (comment)
The existing unit tests have been renamed. The contents of the tests remain identical.
If needed, use regex for executing unit tests
I'd like more suggestions for the naming of the unit tests. I'm not entirely sure if the names are appropriate.