Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc-14 build #5025

Closed
wants to merge 1 commit into from
Closed

Fix gcc-14 build #5025

wants to merge 1 commit into from

Conversation

oleks-rip
Copy link
Collaborator

High Level Overview of Change

Fix fstream usage to be compatible with gcc-14

Context of Change

gcc-14 require explicit definition of the fstream classes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

API Impact

none

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.05%. Comparing base (c88166e) to head (571e259).
Report is 38 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #5025       +/-   ##
============================================
- Coverage    76.97%   60.05%   -16.93%     
============================================
  Files         1129      806      -323     
  Lines       131914    67307    -64607     
  Branches     39629    36826     -2803     
============================================
- Hits        101539    40418    -61121     
+ Misses       24459    19471     -4988     
- Partials      5916     7418     +1502     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bronek
Copy link
Collaborator

Bronek commented May 30, 2024

Note, this broke both MacOS and Windows build, because of no matching constructor for std::ifstream (and std::ostream) from boost::filesystem::path . Try adding .native() calls.

@oleks-rip
Copy link
Collaborator Author

Thank you. I've updated to 2.2.0-rc3 and everything seems ok, without this fix. I'll close it.

@oleks-rip oleks-rip closed this May 30, 2024
@oleks-rip oleks-rip deleted the gcc_14 branch May 30, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants