-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix Github Actions issues #485
Conversation
@@ -32,7 +32,7 @@ jobs: | |||
- name: Install Python + Retrieve Poetry dependencies from cache | |||
uses: actions/setup-python@v4 | |||
with: | |||
python-version: '3.9' | |||
python-version: ${{ env.PYTHON_VERSION }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was it default to 3.9 before? / What is this doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look higher up in the script, you'll see that PYTHON_VERSION
is set as an env var and is set to 3.10. I figured the version that linting was using was supposed to be using 3.10. Also, IMO it's better for the linter to use the most modern fully-supported version of Python, because it'll likely have the best performance.
* refactor: Make request_impl into a private function (#478) * Made request_impl into a private method * refactor: Alias function for safe_sign_transaction called sign (#470) * Create alias for safe_sign_transaction * Update tests to use new submit-transaction alias * fix: fix Github Actions issues (#485) * add better debugging * fix yaml * switch to ubuntu 20.04 * switch back to latest * Revert "switch back to latest" This reverts commit 564002b. * clean up * add 3.11 support Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
* refactor: Make request_impl into a private function (#478) * Made request_impl into a private method * refactor: Alias function for safe_sign_transaction called sign (#470) * Create alias for safe_sign_transaction * Update tests to use new submit-transaction alias * fix: fix Github Actions issues (#485) * add better debugging * fix yaml * switch to ubuntu 20.04 * switch back to latest * Revert "switch back to latest" This reverts commit 564002b. * clean up * add 3.11 support Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
High Level Overview of Change
This PR switches the Github Actions from running on
ubuntu-latest
(which recently switched to 22.04) toubuntu-20.04
, which fixes tests.It also adds testing support for Python 3.11.
Context of Change
Ubuntu 22.04 upgraded OpenSSL to version 3.0, which deprecated ripemd160. Github will not add support to the runner, because they want to run only the default version.
openssl/openssl#16994
actions/runner-images#6676
Type of Change
Test Plan
CI now passes.