Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Github Actions issues #485

Merged
merged 7 commits into from
Dec 1, 2022
Merged

fix: fix Github Actions issues #485

merged 7 commits into from
Dec 1, 2022

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Dec 1, 2022

High Level Overview of Change

This PR switches the Github Actions from running on ubuntu-latest (which recently switched to 22.04) to ubuntu-20.04, which fixes tests.

It also adds testing support for Python 3.11.

Context of Change

Ubuntu 22.04 upgraded OpenSSL to version 3.0, which deprecated ripemd160. Github will not add support to the runner, because they want to run only the default version.

openssl/openssl#16994
actions/runner-images#6676

Type of Change

  • Tests (You added tests for code that already exists, or your new feature included in this PR)

Test Plan

CI now passes.

@@ -32,7 +32,7 @@ jobs:
- name: Install Python + Retrieve Poetry dependencies from cache
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: ${{ env.PYTHON_VERSION }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it default to 3.9 before? / What is this doing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look higher up in the script, you'll see that PYTHON_VERSION is set as an env var and is set to 3.10. I figured the version that linting was using was supposed to be using 3.10. Also, IMO it's better for the linter to use the most modern fully-supported version of Python, because it'll likely have the best performance.

@mvadari mvadari marked this pull request as ready for review December 1, 2022 19:02
@mvadari mvadari merged commit 19bb938 into master Dec 1, 2022
@mvadari mvadari deleted the fix-actions branch December 1, 2022 19:13
connorjchen added a commit that referenced this pull request Dec 1, 2022
* refactor: Make request_impl into a private function (#478)

* Made request_impl into a private method

* refactor: Alias function for safe_sign_transaction called sign (#470)

* Create alias for safe_sign_transaction

* Update tests to use new submit-transaction alias

* fix: fix Github Actions issues (#485)

* add better debugging

* fix yaml

* switch to ubuntu 20.04

* switch back to latest

* Revert "switch back to latest"

This reverts commit 564002b.

* clean up

* add 3.11 support

Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
JST5000 pushed a commit that referenced this pull request Jun 28, 2023
* refactor: Make request_impl into a private function (#478)

* Made request_impl into a private method

* refactor: Alias function for safe_sign_transaction called sign (#470)

* Create alias for safe_sign_transaction

* Update tests to use new submit-transaction alias

* fix: fix Github Actions issues (#485)

* add better debugging

* fix yaml

* switch to ubuntu 20.04

* switch back to latest

* Revert "switch back to latest"

This reverts commit 564002b.

* clean up

* add 3.11 support

Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants