Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] feature beta for sidechain and AMM #2074

Closed
wants to merge 245 commits into from
Closed

[DO NOT MERGE] feature beta for sidechain and AMM #2074

wants to merge 245 commits into from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Sep 1, 2022

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Before / After

Test Plan

mvadari and others added 30 commits August 15, 2022 12:01
@mvadari
Update definitions.json
ad0af1a
@mvadari
add new st types
f0cd854
@mvadari
add tests
ab15f17
@mvadari
add XChainClaim tx
908c871
@mvadari
add XChainCommit tx
e0233a6
@mvadari
add XChainCreateBridge tx
dfbba61
@mvadari
add XChainCreateClaimID tx
1af1c03
@mvadari
update definitions.json
3016a31
@mvadari
rename Bridge -> XChainBridge in binary codec, fix tests
cc20b3f
@mvadari
rename Bridge -> XChainBridge in models
165a2f0
@mvadari
add codec support for XChainAddAttestation
2fb7e1f
@mvadari
add XChainAddAttestation model
a501ab8
@mvadari
undo debugging change
b9606c3
@mvadari
fix linting issues
bb22905
@mvadari
update definitions.json for new rippled code, add new tests/update ol…
c55f168 
…d tests
@mvadari
add/update models
eaa2625
@mvadari
fix models
9a7dcca
@mvadari
fix bugs
b6b52ba
@mvadari
fix more things
9c7f8c6
@mvadari
update history
6946710
@mvadari
update binary-codec
6673474
@mvadari
add XChainModifyBridge model
feb4bff
@khancode
update definitions.json
25bdb69
@khancode
add AMMInstanceCreate
2680c34
@khancode
renamed LPTokens to LPToken in definitions.json
6bcfc2b
@khancode
update HISTORY.md
ff60b54
@khancode
add amm_info RPC command
3461fcc
@khancode
add AMMDeposit
e64a668
@khancode
use null check for missing fields
35fef65
@khancode
add AMMWithdraw
3617487
@mvadari
add/update models
5869fb1
@mvadari
fix models
1faf16f
@mvadari
fix bugs
1283b0a
@mvadari
fix more things
fdbf5ea
@mvadari
update history
cf1404d
@mvadari
update binary-codec
c6b5a9a
@mvadari
add XChainModifyBridge model
e382c21
@mvadari
update RPCs
c821b7d
@mvadari
update to latest rippled
366d6a8
@mvadari
more fixes
ec9e100
@mvadari
fix definitions.json
c44d07f
@mvadari
fix spacing
c5dfe60
@mvadari
update definitions.json to avoid conflict with amm
e9dca34
@mvadari
update definitions.json to resolve amm conflicts
3cf0613
@mvadari
audit code
c529330
@mvadari
more updates
f36bb89
@mvadari
fix renames
b5ac995
@mvadari
fix linter
01d7e71
@mvadari
update rpcs
0c0de6f
@mvadari
switch to beta version
73c0f2c
@mvadari
fix copy-paste typo
1bb1980
@mvadari
add destination tag to XChainClaim
f1094ad
@mvadari
rename IssuedCurrency -> Issue to match rippled
56bbd8c
@mvadari
update Issue form
305672d
@mvadari
fix account object filters
8cb1ad2
@mvadari
fix issue from typing
7a71171
@mvadari
Merge branch 'sidechain-2.5' into beta
1befce5
@dangell7 dangell7 mentioned this pull request Dec 23, 2022
Open
@khancode khancode closed this May 17, 2023
@khancode khancode deleted the beta branch May 17, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvadari @khancode