Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add input check for OracleSet params AssetPrice and Scale #2699

Merged
merged 3 commits into from
May 23, 2024
Merged

feat: add input check for OracleSet params AssetPrice and Scale #2699

merged 3 commits into from
May 23, 2024

Conversation

khancode
Copy link
Collaborator

@khancode khancode commented May 23, 2024 •
edited
Loading

High Level Overview of Change

Add input check for OracleSet params AssetPrice and Scale either being both present or excluded.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update HISTORY.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Added unit tests to verify this validation.

@khancode khancode requested review from mvadari and pdp2121 May 23, 2024 18:22
@khancode khancode requested a review from mvadari May 23, 2024 21:23
@khancode khancode merged commit b27bbb4 into main May 23, 2024
15 checks passed
@khancode khancode deleted the price-oracle-input-check branch May 23, 2024 21:32
ckeshava pushed a commit to ckeshava/xrpl.js that referenced this pull request Jun 12, 2024
@khancode @ckeshava
feat: add input check for OracleSet params AssetPrice and Scale (…
0d88883 
…XRPLF#2699)

* add input check for AssetPrice and Scale being either both present or excluded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdp2121 pdp2121 pdp2121 approved these changes

@mvadari mvadari mvadari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khancode @mvadari @pdp2121