Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to Node 18 and remove cross-fetch (#2678) #2737

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

ckeshava
Copy link
Collaborator

  • feat: Upgrade to Node 18 and remove cross-fetch

BREAKING CHANGE: fetch now relies on the native javascript environment in browsers and node.js

  • fix typo in HISTORY.md file

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update HISTORY.md?

  • Yes
  • No, this change does not impact library users

Test Plan

@ckeshava
Copy link
Collaborator Author

This PR has been reviewed at #2678

Copy link

socket-security bot commented Jul 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@noble/curves@1.4.0 None 0 1.39 MB paulmillr
npm/@scure/base@1.1.6 None 0 80.4 kB paulmillr
npm/@types/lodash@4.17.1 None 0 862 kB types
npm/@types/node@18.19.39 None 0 1.97 MB types

🚮 Removed packages: npm/@noble/curves@1.4.2, npm/@scure/base@1.1.7, npm/@types/lodash@4.17.6, npm/@types/node@16.18.46, npm/cross-fetch@4.0.0

View full report↗︎

@ckeshava
Copy link
Collaborator Author

@justinr1234 Do you know why the Github UI displays Node 16 in these CI/CD options?
image

I have updated three more instances of Node 16 in this commit: af27476

I couldn't find any other remnants of Node 16 in the codebase.

@justinr1234
Copy link
Collaborator

@ckeshava it will continue running the test on the base branch (main) until you merge in these changes

justinr1234 and others added 2 commits July 16, 2024 12:54
* feat: Upgrade to Node 18 and remove cross-fetch

BREAKING CHANGE: fetch now relies on the native javascript environment in browsers and node.js

* fix typo in HISTORY.md file

---------

Co-authored-by: Chenna Keshava B S <ckeshavabs@gmail.com>
@ckeshava ckeshava merged commit 3bc3c20 into main Jul 16, 2024
12 checks passed
@ckeshava ckeshava deleted the xrpl-4.0.0 branch July 16, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants