Fix failing AMM IT #536
Merged
Fix failing AMM IT #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sappenin
commented
May 22, 2024
sappenin
commented
- Reduce default amount of XRP in ITs to conform to new 100 XRP faucet policies.
- Update ammendments
- Update rippled container to v2.2
* Reduce default amount of XRP in ITs to conform to new 100 XRP faucet policies. * Update ammendments * Update rippled container to v2.2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=========================================
Coverage 91.65% 91.65%
Complexity 1774 1774
=========================================
Files 365 365
Lines 4948 4948
Branches 408 408
=========================================
Hits 4535 4535
Misses 280 280
Partials 133 133 ☔ View full report in Codecov by Sentry. |
nkramer44
approved these changes
May 23, 2024
|
Merging this because, despite what this dashboard is showing, we have a passing build on testnet reporting and testnet clio (there's one build for the commit push and one for the PR in each environment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.