Misc fixes for GUID regeneration issues #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set GUID regeneration to FALSE by default - GUID regeneration has to be specifically called
SimonDarksideJ
added
the
Ready for review
StephenHodgson
approved these changes
Dec 16, 2020
FejZa
approved these changes
Dec 16, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Initial check-in for agreed changes for asset referencing issues: - Set GUID regeneration to FALSE by default - GUID regeneration has to be specifically called * Reverted changes to include GUID registry * Updated docs to refer to known potential issues * Updated formatting and added mitigation for known issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Since the move to place the default profiles and prefabs for all the various platforms to HIDDEN folders, there isn't actually a need to regenerate the GUID's for copied assets by default.
This ensures that any references between packages are retained as the asset guids remain unchanged when copied to a project's asset folder. And since the originals are in hidden folders, there is no conflict anymore.
The facility remains should it be needed, it is simply now OFF by default
Changes
Following discussions, the following changes were agreed (following on from PR #717
Updated the default for GUID regeneration to FALSE within the Core Package Installer script.
Reverted GUID cache changes
Added Known Issues documentation to warn developers about changing XRTK.Generated content
Fixes: SDK references are lost when a Specific Platform has a dependency #706
Tested in a new project without issue and previous referencing issues are no longer a problem.