-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nodejs): ✨ handle engine versions and package installs #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Pull requests that update a dependency file
rust
Pull requests that update Rust code
labels
Jul 1, 2024
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jul 2, 2024
XaF
changed the title
feat(nodejs): ✨ handle engine versions
feat(nodejs): ✨ handle engine versions and package installs
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request
javascript
Pull requests that update Javascript code
rust
Pull requests that update Rust code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
package.json
, Node can define a number ofengines
and the relative versions that are needed for it. This was not directly supported while we were already looking atpackage.json
to figure out the version of node to be installed.This now adds support to ensure that
npm
,pnpm
,yarn
,electron
and other engines are installed in the required versions for the current environment. This also creates an isolation path for node to runnpm install -g
and install tools only for the current work directory.This also adds support for running
npm install
,pnpm install
oryarn install
automatically depending on the lock files that are present in the directory, as well as theengines
listed in thepackage.json
file.Both those behaviors default to be enabled, but can be disabled by setting
install_engines
andinstall_packages
tofalse
when setting up thenode
operation.Closes #293
Closes #294