Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [refactor] centralize the generation of the device payload #70

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

XaF
Copy link
Owner

@XaF XaF commented Jan 7, 2023

The device payload allows to link all of our entities to a unique device in Home Assistant. So far, we were generating the payload distinctly in every payload configuration. With this change, we put that device payload on a method to ensure that this payload stays identical across entities.

The device payload allows to link all of our entities to a unique
device in Home Assistant. So far, we were generating the payload
distinctly in every payload configuration. With this change, we
put that device payload on a method to ensure that this payload
stays identical across entities.
@XaF XaF added the enhancement New feature or request label Jan 7, 2023
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py170100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py239797%165, 213, 216, 334, 385, 463, 537
   utils.py200100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py651282%61–62, 64, 68, 73, 88–100, 110, 139
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%64, 69, 100, 104, 130–131, 163, 167, 190, 201, 208, 235, 251, 265, 278–280, 325, 357, 369, 414
   exceptions.py290100% 
   observable.py17382%13, 17–18
   partition.py120794%149–153, 159–163, 166
   sensors.py1792288%51–72, 116, 120, 126, 155, 159, 166, 183, 187
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py64395%24, 74, 82
   utils.py32488%10, 13, 19–20
TOTAL151914690% 

Tests Skipped Failures Errors Time
111 0 💤 0 ❌ 0 🔥 29.058s ⏱️

@XaF XaF merged commit 68c36d1 into main Jan 7, 2023
@XaF XaF deleted the xaf/refactor_mqtt_device_payload branch January 7, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant