Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [feature] Add support for tampered sensors #74

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

XaF
Copy link
Owner

@XaF XaF commented Jan 8, 2023

This adds a tampered attribute to sensors indicating if the sensor is currently believed to be tampered with or not.

This is not 100% accurate as it depends on specific sets of events that the panel is sending in a given order, which allow to guess if a sensor is currently tampered or not. This should be taken with a huge grain of salt as, for instance, we do not have that information when getting the summary state for the sensors from the panel (and will be able to know a sensor was tampered when it won't be tampered anymore).

More details are available at #73 as to the identified interactions and how they are implemented here.

Closes #73

@XaF XaF added the enhancement New feature or request label Jan 8, 2023
@XaF XaF force-pushed the xaf/support_for_tampered_sensors branch from 37f5f61 to 286d660 Compare January 8, 2023 20:00
@github-actions

This comment has been minimized.

@XaF XaF force-pushed the xaf/support_for_tampered_sensors branch from 286d660 to e639163 Compare January 8, 2023 20:31
@github-actions

This comment has been minimized.

This adds a `tampered` attribute to sensors indicating if the
sensor is currently believed to be tampered with or not.

This is not 100% accurate as it depends on specific sets of events
that the panel is sending in a given order, which allow to guess
if a sensor is currently tampered or not. This should be taken with
a huge grain of salt as, for instance, we do not have that
information when getting the summary state for the sensors from the
panel (and will be able to know a sensor was tampered when it won't
be tampered anymore).

More details are available at #73
as to the identified interactions and how they are implemented here.
@XaF XaF force-pushed the xaf/support_for_tampered_sensors branch from e639163 to 4e02ace Compare January 8, 2023 20:34
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py170100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py238797%164, 212, 215, 333, 384, 462, 540
   utils.py50100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py701381%63–64, 66, 70, 75, 90–102, 112, 120, 146
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%64, 69, 100, 104, 130–131, 163, 167, 190, 201, 208, 235, 251, 265, 278–280, 325, 357, 369, 414
   exceptions.py290100% 
   observable.py17382%13, 17–18
   partition.py120794%149–153, 159–163, 166
   sensors.py2052090%57–78, 136, 194, 198, 205, 222, 226
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py64395%24, 74, 82
   utils.py47491%11, 14, 20–21
TOTAL154914591% 

Tests Skipped Failures Errors Time
118 0 💤 0 ❌ 0 🔥 31.743s ⏱️

@XaF XaF merged commit 4b7bed0 into main Jan 8, 2023
@XaF XaF deleted the xaf/support_for_tampered_sensors branch January 8, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for tampered sensors as a tampered attribute on the sensor itself
1 participant