Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosmos db support #140

Merged
merged 10 commits into from
Apr 9, 2019
Merged

Conversation

ahmagdy
Copy link
Contributor

@ahmagdy ahmagdy commented Apr 3, 2019

Adding CosmosDb support, because documentdb will be deprecated.
I followed the same flow of documentdb and didn't delete it, so the maintainers can remove documentDb when it's officially deprecated.
I used ConnectionString instead of Uri and access token because i think it's simpler and easier to use.

Copy link
Collaborator

@unaizorrilla unaizorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!! Can you change the package version as I mentioned on?

@@ -84,6 +85,7 @@
<HealthCheckSystem>2.2.1</HealthCheckSystem>
<HealthCheckNetwork>2.2.2</HealthCheckNetwork>
<HealthCheckDynamoDb>2.2.0</HealthCheckDynamoDb>
<HealthCheckCosmosDb>2.2.0</HealthCheckCosmosDb>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this package use preview packages, set also as preview version, 2.2.0-preview!

@ahmagdy
Copy link
Contributor Author

ahmagdy commented Apr 4, 2019

@unaizorrilla Great!
Done.

@unaizorrilla unaizorrilla merged commit 2c1eef1 into Xabaril:master Apr 9, 2019
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants