Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an AddUrlGroup extension method where Uri is provided by IServiceProvider #554

Merged

Conversation

rwwilden
Copy link

@rwwilden rwwilden commented Jun 9, 2020

What this PR does / why we need it:
In some cases, the Uri for a UriHealthCheck is available from configuration through an IOptions<...> instance. It should be possible to use this IOptions<...> instance by retrieving it from the IServiceProvider instead of pulling the Uri directly from config yourself.

Which issue(s) this PR fixes:
No issue was reported.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
No, just an additional UriHealthCheck registration possibility.

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@unaizorrilla unaizorrilla self-requested a review June 9, 2020 15:29
@unaizorrilla unaizorrilla added the enhancement New feature or request label Jun 9, 2020
@unaizorrilla unaizorrilla self-assigned this Jun 9, 2020
@unaizorrilla unaizorrilla merged commit f25fb87 into Xabaril:master Jun 9, 2020
@unaizorrilla
Copy link
Collaborator

Hi @rwwilden

Merged, thanks for contribute this, a release build is on appveyor, when finished a new package 3.1.2 will be available on NuGet.

@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants