Add python code for the labudde algorithm #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 22 +1
Lines 1456 1469 +13
=========================================
+ Hits 1456 1469 +13
Continue to review full report at Codecov.
|
|
sc-11656 |
thisac
approved these changes
Dec 2, 2021
Co-authored-by: Theodor <theodor@xanadu.ai>
* More pythonic * Minor typos * Minor typos * Update thewalrus/tests/test_labudde.py * Minor typos Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain>
nquesada
reviewed
Dec 2, 2021
nquesada
reviewed
Dec 2, 2021
nquesada
reviewed
Dec 2, 2021
nquesada
reviewed
Dec 2, 2021
nquesada
reviewed
Dec 2, 2021
|
@trevor-vincent , @thisac : the only thing missing is to update the CHANGELOG. |
nquesada
reviewed
Dec 2, 2021
nquesada
reviewed
Dec 3, 2021
thisac
approved these changes
Dec 3, 2021
Co-authored-by: Nicolas Quesada <991946+nquesada@users.noreply.github.com>
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
There is C++ code for the labudde characteristic polynomial algorithm but no python code for it.
Description of the Change:
Adds python code for the labudde characteristic polynomial algorithm
Benefits:
Power traces and characteristic polynomials can be computed using the labudde algorithm using python.
Possible Drawbacks:
None
Related GitHub Issues:
None