Removes all remaining C++ files and implements hafnian functions in pure python using numba #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…walrus into hafnian_with_jake_code
…walrus into hafnian_with_jake_code
…walrus into hafnian_with_jake_code
…walrus into hafnian_with_jake_code
…walrus into hafnian_with_jake_code
…walrus into hafnian_with_jake_code
…walrus into hafnian_with_jake_code
…walrus into hafnian_with_jake_code
…walrus into hafnian_with_jake_code
Removed hafnian cpp implementations
…into docs-remove-cpp
nquesada
commented
Dec 15, 2021
| @@ -119,45 +93,19 @@ To ensure that The Walrus library is working correctly after installation, the t | |||
|
|
|||
| $ make test | |||
There was a problem hiding this comment.
@sduquemesa : is this line still needed?
nquesada
commented
Dec 15, 2021
| @@ -89,7 +89,7 @@ The Walrus Documentation | |||
| Features | |||
| ======== | |||
|
|
|||
| * Fast calculation of hafnians, loop hafnians, and torontonians of general and certain structured matrices. | |||
| * Fast calculation of hafnians, loop hafnians, and torontonians of general and certain structured matrices powered by `Numba <https://numba.pydata.org/>`_. | |||
|
😍 My only comment is that the name of this page in the docs https://hafnian--311.org.readthedocs.build/en/311/code/thewalrus.html probably doesn't make any sense any more, since the entire library is now Python? |
thisac
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.