Fix size-0 matrix permanents #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue XanaduAI#319 by checking 0 size matrices and returning one in permanent computations
remove unnecessary whitespace
Fixed formatting
thisac
reviewed
Jan 17, 2022
There was a problem hiding this comment.
Looks great @GregoryMorse! Don't forget to add an entry to the changelog and your name to the list of contributors. Thanks a lot for your contribution! 💯
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 1568 1572 +4
=========================================
+ Hits 1568 1572 +4
Continue to review full report at Codecov.
|
nquesada
reviewed
Jan 17, 2022
1 task
|
@GregoryMorse Just missing an entry to the changelog, and then we can merge the PR. You can simply add an entry under |
thisac
reviewed
Jan 24, 2022
thisac
reviewed
Jan 24, 2022
thisac
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Permanent computations with size 0 returning incorrect values, with size 1 not optimized
Description of the Change:
Fix 0x0 and optimize 1x1 cases for permanent
Benefits:
0x0 matrices have correct output, 1x1 are faster
Possible Drawbacks:
None
Related GitHub Issues:
#319