-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix size-0 matrix permanents #320
Conversation
Fix issue XanaduAI#319 by checking 0 size matrices and returning one in permanent computations
remove unnecessary whitespace
Fixed formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @GregoryMorse! Don't forget to add an entry to the changelog and your name to the list of contributors. Thanks a lot for your contribution! 💯
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 1568 1572 +4
=========================================
+ Hits 1568 1572 +4
Continue to review full report at Codecov.
|
@GregoryMorse Just missing an entry to the changelog, and then we can merge the PR. You can simply add an entry under |
Context:
Permanent computations with size 0 returning incorrect values, with size 1 not optimized
Description of the Change:
Fix 0x0 and optimize 1x1 cases for permanent
Benefits:
0x0 matrices have correct output, 1x1 are faster
Possible Drawbacks:
None
Related GitHub Issues:
#319