-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add infinispan java 11 module #132
Conversation
Signed-off-by: iProdigy <8106344+iProdigy@users.noreply.github.com>
...nispan14/src/main/java/io/github/xanthic/cache/provider/infinispan/Infinispan14Listener.java
Outdated
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/Xanthic/cache-api/132.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/Xanthic/cache-api/132.diff | git apply Once you're satisfied, commit and push your changes in your project. Footnotes |
What do you think about these names?
This is easier to maintain as most infinispan releases won't change the java version requirement. |
Good idea - is |
...n-java11/src/main/java/io/github/xanthic/cache/provider/infinispan/Infinispan14Delegate.java
Outdated
Show resolved
Hide resolved
We could also differentiate using the package:
This way we can keep the same names / copy all files between the two packages. (at least until a breaking change affects the code) If we change the name, i would prefer |
Signed-off-by: iProdigy <8106344+iProdigy@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Closes #123
Separate module due to Java 11 requirement