Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add infinispan java 11 module #132

Merged
merged 7 commits into from
Jun 13, 2023
Merged

Conversation

iProdigy
Copy link
Member

Closes #123

Separate module due to Java 11 requirement

Signed-off-by: iProdigy <8106344+iProdigy@users.noreply.github.com>
@sonatype-lift
Copy link

sonatype-lift bot commented Jun 12, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/Xanthic/cache-api/132.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/Xanthic/cache-api/132.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@PhilippHeuer
Copy link
Member

PhilippHeuer commented Jun 12, 2023

What do you think about these names?

  • cache-provider-infinispan
  • cache-provider-infinispan-java11

This is easier to maintain as most infinispan releases won't change the java version requirement.
The suffix -java11 seems to be used a lot in such cases, see https://central.sonatype.com/search?smo=true&q=-java11.

@iProdigy
Copy link
Member Author

Good idea - is Infinispan11Delegate too ambiguous (jdk 11 or lib v11)?

@iProdigy iProdigy changed the title feat: add infinispan v14 module feat: add infinispan java 11 module Jun 13, 2023
@PhilippHeuer
Copy link
Member

PhilippHeuer commented Jun 13, 2023

We could also differentiate using the package:

  • io.github.xanthic.cache.provider.infinispan
  • io.github.xanthic.cache.provider.infinispanjdk11

This way we can keep the same names / copy all files between the two packages. (at least until a breaking change affects the code)

If we change the name, i would prefer InfinispanJava11Delegate to ensure users don't think it's infinispan v11.

iProdigy and others added 4 commits June 13, 2023 14:36
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
65.9% 65.9% Duplication

@iProdigy iProdigy merged commit 900eba6 into main Jun 13, 2023
@iProdigy iProdigy deleted the feature/infinispan-14-module branch June 13, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants