Improve signing experience when using non-english keyboard #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Sometimes, we can not type password when we forgot to switch back to English keyboard.
Fix
It may related to a focus issue, so I added a
.focusedmodifier to resolve the issue.I think that might because when
SecurityFieldgets focus, it automatically switches to English while in process,SecurityFieldloses the focus ( not sure why ).By implementing the fix, it works correctly in any situation.
Comparison
Here is a comparison video for you to checkout what I have resolved.
keyboard-input.issue.mov