Consolidate versions from both download sites #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Xcode 11 beta 6, developer.apple.com/download and developer.apple.com/download/more both list some pre-release versions of Xcode. Previously pre-release versions only appeared on developer.apple.com/download. /download/more doesn't include build numbers, so we trust that if the version number and prerelease identifiers are the same that they're the same build. If an Xcode version is listed on both sites then prefer the one on /download because the build metadata is used to compare against installed Xcodes. Because pre-release versions that are installed also have build metadata, but this won't be the case for pre-release versions listed on /download/more, we also need to replace versions that are available with the installed ones with build metadata before printing them.
MattKiazyk
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Xcode 11 beta 6, developer.apple.com/download and developer.apple.com/download/more both list (some) pre-release versions of Xcode. Previously, pre-release versions only appeared on developer.apple.com/download. /download/more doesn't include build numbers, so we trust that if the version number and prerelease identifiers are the same as one on /download then they're the same build. If an Xcode version is listed on both sites then we prefer the one on /download because the build metadata is used later to compare against installed Xcodes.
Because pre-release versions that are installed also have build metadata, but this won't be the case for pre-release versions listed on /download/more, we also need to replace versions that are available with the installed ones with build metadata before printing them.
Resolves #67
Testing
Before:
After: