Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Foxcord configuration and role behaviour #6

Closed
Xeckt opened this issue Nov 9, 2021 · 1 comment · Fixed by #12
Closed

Adjust Foxcord configuration and role behaviour #6

Xeckt opened this issue Nov 9, 2021 · 1 comment · Fixed by #12
Assignees
Labels
enhancement New feature or request good first issue Good issue for beginners and new-comers

Comments

@Xeckt
Copy link
Owner

Xeckt commented Nov 9, 2021

  • enableBotLog is part of bot rather than logData or an object dedicated to logging

  • logData appears to be using single files for each type of logging, but this won't scale with time, and those individiual files will just get bigger. it's better to split logs taken up by day ie. yyyymmdd in the filename which makes the relevant logs you're looking for easier to find and makes it easier to delete/archive older logs (edited)

  • commandData having enableuserCommands, enableModCommands, etc. implies a built in categorization system, which isn't necessarily a bad thing, but it means that whatever system of categories isn't easily customizable/is hardcoded. same thing for
    userId, modId, etc.

  • userId, modId, etc. implies singular ids, multiple people being able to have the same role is a common expectation of permission and hierarchy systems, especially if mod refers to moderator in the context of moderating servers

Credit: 06000208

@Xeckt Xeckt added enhancement New feature or request good first issue Good issue for beginners and new-comers labels Nov 9, 2021
@Xeckt Xeckt self-assigned this Nov 9, 2021
@Xeckt
Copy link
Owner Author

Xeckt commented Nov 9, 2021

For the last point, it seems to just be because of the naming inside the json config, I will adjust the naming to make it clearer the Id's are for roles and not for users individually.

Having the command categorisation will most likely stay because it's a neatly modular way to handle commands and sticks to the discordpy cog conventions, just applied in a different way. This bot is intended for beginners or people looking for a base bot, so things like that are easily adjusted by the user. Documentation covering this will come later.

However, we do need a dynamic command permissions system. I'll write a seperate issue for that.

Xeckt added a commit that referenced this issue Nov 10, 2021
Additional change of having bot modes for different environments which can display specific data on bot start for debugging / development purposes
@Xeckt Xeckt closed this as completed in #12 Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good issue for beginners and new-comers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant