You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
enableBotLog is part of bot rather than logData or an object dedicated to logging
logData appears to be using single files for each type of logging, but this won't scale with time, and those individiual files will just get bigger. it's better to split logs taken up by day ie. yyyymmdd in the filename which makes the relevant logs you're looking for easier to find and makes it easier to delete/archive older logs (edited)
commandData having enableuserCommands, enableModCommands, etc. implies a built in categorization system, which isn't necessarily a bad thing, but it means that whatever system of categories isn't easily customizable/is hardcoded. same thing for
userId, modId, etc.
userId, modId, etc. implies singular ids, multiple people being able to have the same role is a common expectation of permission and hierarchy systems, especially if mod refers to moderator in the context of moderating servers
For the last point, it seems to just be because of the naming inside the json config, I will adjust the naming to make it clearer the Id's are for roles and not for users individually.
Having the command categorisation will most likely stay because it's a neatly modular way to handle commands and sticks to the discordpy cog conventions, just applied in a different way. This bot is intended for beginners or people looking for a base bot, so things like that are easily adjusted by the user. Documentation covering this will come later.
However, we do need a dynamic command permissions system. I'll write a seperate issue for that.
enableBotLog
is part of bot rather thanlogData
or an object dedicated to logginglogData
appears to be using single files for each type of logging, but this won't scale with time, and those individiual files will just get bigger. it's better to split logs taken up by day ie. yyyymmdd in the filename which makes the relevant logs you're looking for easier to find and makes it easier to delete/archive older logs (edited)commandData
having enableuserCommands, enableModCommands, etc. implies a built in categorization system, which isn't necessarily a bad thing, but it means that whatever system of categories isn't easily customizable/is hardcoded. same thing foruserId, modId, etc.
userId
,modId
, etc. implies singular ids, multiple people being able to have the same role is a common expectation of permission and hierarchy systems, especially if mod refers to moderator in the context of moderating serversCredit: 06000208
The text was updated successfully, but these errors were encountered: