Reorganize commands (user facing + directory structure) #29

rsek · 2022-01-23T03:30:22Z

aside from renames, includes some additional description. /progress and /clock are now collapsed into single commands, but i've also retained the command group versions in separate files; once discord has a more sensible display for subcommand groups, i may bring them back in that format (mainly so i can better annotate the nuances of the individual progress/clock types)

also resolves #37

user command organization:

directory structure:

rsek · 2022-01-24T02:28:31Z

rebased with #27

This reverts commit 783bda3.

This reverts commit f52d292.

This reverts commit a1a4cce.

This reverts commit cc82fa2.

rsek · 2022-01-27T02:02:23Z

TheOracle2/Interactions/MessageCommands/RecreateMessageCommand.cs

@@ -3,9 +3,9 @@

 namespace TheOracle2.Commands;

-public class RightClickCommands : InteractionModuleBase<SocketInteractionContext>
+public class RecreateMessageCommand : InteractionModuleBase<SocketInteractionContext>


more descriptive name, since it's a module of one command atm; add'l MessageCommands can live as their own modules in the MessageCommands directory

rsek · 2022-01-27T02:05:13Z

TheOracle2/Clock/CampaignClock.cs

@@ -11,7 +11,7 @@ public CampaignClock(ClockSize segments, int filledSegments, string title, strin
    }

    public override string EmbedCategory => "Campaign Clock";
-    public override string LogMessage => "The event is triggered or the project is complete. Envision the outcome and the impact on your setting.";
+    public override string ClockFillMessage => "The event is triggered or the project is complete. Envision the outcome and the impact on your setting.";


some widgets can produce more than one kind of alert output (scene challenges for instance, which are both a clock and a progress track), so a single LogMessage won't work for them

rsek · 2022-01-27T02:08:10Z

TheOracle2/Clock/CampaignClock.cs

-        return new ComponentBuilder().WithSelectMenu(menu);
+        return new ComponentBuilder()
+            .WithSelectMenu(menu)
+            // .WithButton(ILogWidget.ToggleAlertButton(AlertOnIncrement))


sounds like we're going a different direction with log output, but if it's NBD i'd prefer to leave this here commented out for now.

rsek · 2022-01-27T02:11:25Z

TheOracle2/Commands/ActionRollCommand.cs

@@ -1,28 +0,0 @@
-using Discord.Interactions;


functionality moved to RollCommandGroup.cs

rsek · 2022-01-27T02:11:51Z

TheOracle2/Commands/EditPlayerCommands.cs

@@ -1,139 +0,0 @@
-using Discord.Interactions;


functionality moved to PlayerCharacterCommandGroup & EditPcComponents

rsek · 2022-01-27T02:13:07Z

TheOracle2/Commands/ProgressRollCommand.cs

@@ -1,24 +0,0 @@
-using Discord.Interactions;


functionality moved to RollCommandGroup

rsek · 2022-01-27T02:13:42Z

TheOracle2/Commands/UtilityComponents.cs

@@ -1,20 +0,0 @@
-using Discord.Interactions;


merged with GenericComponents

rsek · 2022-01-27T02:15:42Z

TheOracle2/Interactions/SlashCommands/AskTheOracleCommand.cs

    public async Task AskTheOracle(
-        [Summary(description: "The odds of receiving a 'yes'.")]


this one's a legit bugfix 🤦 currently they're inverted from where they ought to be

rsek · 2022-01-27T02:16:30Z

TheOracle2/Interactions/SlashCommands/AssetCommand.cs

@@ -17,7 +17,7 @@ public AssetCommand(EFContext dbContext, Random random)
    public EFContext DbContext { get; }
    public Random Random { get; }

-    [SlashCommand("asset", "Generates an asset")]
+    [SlashCommand("asset", "Display an interactive asset card (p. 50).")]


"generate" could imply generating custom content

rsek · 2022-01-27T02:17:51Z

TheOracle2/Interactions/SlashCommands/ClockCommand.cs

@@ -0,0 +1,100 @@
+using Discord.Interactions;


a "collapsed" version of the previous clock command group. i've retained the command group version in case we want to switch back later, once discord handled subcommand displays more gracefully.

rsek · 2022-01-27T02:21:43Z

TheOracle2/Interactions/SlashCommands/PlayerCharacterCommandGroup.cs

@@ -0,0 +1,85 @@
+using Discord.Interactions;


the /player-character group is intended for "meta" operations: creating, deleting, setting attribute values (rather than incrementing/decrementing), etc. since typically they're used relatively infrequently (once a session at most), it's not a big deal if they're 'gated' behind a lengthy (but descriptive) command group name.

rsek · 2022-01-27T02:24:19Z

TheOracle2/Interactions/SlashCommands/ProgressTrackCommand.cs

@@ -0,0 +1,116 @@
+using Discord.Interactions;


this being a single command has the same rationale as /clock, above

name change rationale: progress-track is a little more descriptive (and cleaves close to the book/asset text - iirc 'track' alone doesn't show up too often). it also means that someone who starts typing /progress (which i suspect is the first thing many people will try when seeking progress track related commands) will see this command.

rsek · 2022-01-27T02:42:53Z

TheOracle2/Interactions/SlashCommands/RollCommandGroup.cs

@@ -7,9 +7,10 @@

 namespace TheOracle2;

-public class PlayerRollCommand : InteractionModuleBase
+[Group("roll", "Make an action roll (p. 28) or progress roll (p. 39). For oracle tables, use '/oracle'")]


i figure /roll is what people will try first for action/progress rolls, and this means people only have to remember one command to execute the most common game functions.

i think a command group is the best solution here. for one, /roll is very brief. for another, as top-level commands they'd have to be named /roll-action and /roll-progress to function that way, which doesn't actually save many (if any) keystrokes

rsek · 2022-01-27T04:48:11Z

resolves #37

rsek force-pushed the reorganize-commands branch from 6771e4d to 1c6bd90 Compare January 24, 2022 01:39

This was referenced Jan 24, 2022

Impact and momentum tweaks #33

Draft

Components cannot change without generating a new discord message #18

Closed

GuildPlayer + last character used as default for pc-action-roll #27

Merged

rsek added 25 commits January 25, 2022 20:59

mv to Clock dir, add'l overload

efa13c1

combine ironsworn roll commands to group

3059e32

minor description changes

1e1854f

directory for disabled commands

11ad0a3

directory for component handlers

70c735c

description tweak + page ref

e1605ed

/player command group

19d21c3

change description to reflect new command

c8f892e

alternative structure as single command

af267ed

mv to Clock dir

9180903

normalizing descriptions

4c4826b

adding missing periods

f5d82dd

rename to GenericComponents

1054856

merge UtilityComponents w/ GenericComponents

4a3640c

dir "Commands" => "Interactions" with subdirs

9863881

ditching DisabledCommands dir

20047fc

add note about /ask to /oracle

f5eb33f

reorder imports

ce4f05f

added period to end of command description

78fede4

fixed inverted clock labels

dae35b4

fixing clock values

2ffad6c

split components files+fix missing cmd: earned-exp

7028fc6

adjusting clock option description

87fbacf

fixing Alert toggles (default to "off")

29eee53

comment out alert toggles; track roll embeds links

2303608

rsek added 12 commits January 26, 2022 17:05

Revert "whitespace changes"

2089631

This reverts commit 783bda3.

Revert "corrected comment"

02a9a5c

This reverts commit f52d292.

Revert "whitespace changes"

31a223f

This reverts commit a1a4cce.

Revert "tweak whitespace"

fb92df9

This reverts commit cc82fa2.

matching main branch whitespace

569a881

match main whitespace

c791a82

adjust whitespace to match main

574f984

whitespace, rm comment, replace removed exception

0fd5fa4

matching main whitespace

eb68c04

match main whitespace

a8ee182

match whitespace

b6f6d22

rename to follow convention

de34e3a

rsek commented Jan 27, 2022

View reviewed changes

rename to match convention

8a6dbe1

rsek commented Jan 27, 2022

View reviewed changes

TheOracle2/Commands/UtilityComponents.cs

@@ -1,20 +0,0 @@

using Discord.Interactions;

Copy link

Contributor Author

rsek Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged with GenericComponents

rsek commented Jan 27, 2022

View reviewed changes

"OracleAskPaths" => "AskTheOracleCommand"

d625952

rsek mentioned this pull request Jan 27, 2022

bug: Ask the Oracle odds are inverted #37

Closed

XenotropicDev merged commit e8850cc into XenotropicDev:main Feb 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorganize commands (user facing + directory structure) #29

Reorganize commands (user facing + directory structure) #29

rsek commented Jan 23, 2022 •

edited

Loading

rsek commented Jan 24, 2022 •

edited

Loading

rsek Jan 27, 2022

rsek Jan 27, 2022

rsek Jan 27, 2022

rsek Jan 27, 2022

rsek Jan 27, 2022 •

edited

Loading

rsek Jan 27, 2022

rsek Jan 27, 2022

rsek Jan 27, 2022

rsek Jan 27, 2022

rsek Jan 27, 2022

rsek Jan 27, 2022 •

edited

Loading

rsek Jan 27, 2022 •

edited

Loading

rsek Jan 27, 2022

rsek commented Jan 27, 2022

		public async Task AskTheOracle(
		[Summary(description: "The odds of receiving a 'yes'.")]

Reorganize commands (user facing + directory structure) #29

Reorganize commands (user facing + directory structure) #29

Conversation

rsek commented Jan 23, 2022 • edited Loading

rsek commented Jan 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rsek Jan 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rsek Jan 27, 2022 • edited Loading

Choose a reason for hiding this comment

rsek Jan 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rsek commented Jan 27, 2022

rsek commented Jan 23, 2022 •

edited

Loading

rsek commented Jan 24, 2022 •

edited

Loading

rsek Jan 27, 2022 •

edited

Loading

rsek Jan 27, 2022 •

edited

Loading

rsek Jan 27, 2022 •

edited

Loading