Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce user agent #18

Merged
merged 3 commits into from
May 2, 2017
Merged

Conversation

jordanwalsh23
Copy link
Contributor

Sets a default user agent when this has not been set in the config file.

jordanwalsh23 and others added 3 commits April 28, 2017 16:50
When the user agent was not provided in the config file, the logs were showing 'undefined'.  This has now been defaulted to the ConsumerKey for the customer to help identify this in alerting and monitoring.

We've also included a 'warn' log statement advising this may be set as mandatory in future.
@jordanwalsh23 jordanwalsh23 merged commit 485f3aa into XeroAPI:master May 2, 2017
@jordanwalsh23 jordanwalsh23 deleted the enforce_user_agent branch May 2, 2017 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant