Merging PR#63 with tests updated #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backwards merge
Backwards Merge
Backwards merge
Backwards merge
removed sample app and dev dependencies
…nolog4js # Conflicts: # docs/Sample-App-Setup.md # sample_app/index.js
Backwards merge
added 2 commits
July 27, 2017 15:56
|
Just making sure it was intended: This also pulls in #59 |
|
I'm getting When I try to run tests. |
|
Resovled the q issue. Will PR the fix once green. |
|
Here is the PR which makes this Green. It's to your folk @jordanwalsh23 which will update this PR. Nice work. Lots of linting errs there so good chance for someone to send PRs. |
Adds mocha as a dev dependancy and removes q as it was not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the changes in #63 but the tests have been updated to abide by the eslint checks.
All green.