-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Get/Post support, Test refactoring & ESLint fixes #65
Conversation
Backwards merge
Not sure why these fail now. Have not investigated. |
I'll clean my demo company and run again. I think it's because I have got a
different data set.
…On 3 Aug. 2017 6:15 am, "Phil Alsford" ***@***.***> wrote:
Not sure why these fail now. Have not investigated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#65 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABUxiDUrA-SYsikwwzvLb6eAByq-37Zfks5sUNj7gaJpZM4OqfUy>
.
|
So I ran master against the same Org and get 100% passes |
Yep. It's not creating enough dependant data for the tests. Thanks for
testing.
…On 3 Aug. 2017 8:45 am, "Phil Alsford" ***@***.***> wrote:
So I ran master against the same Org and get 100% passes
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#65 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABUxiIkUVoStjayTvU3IDm4GQtMg8tv3ks5sUPwfgaJpZM4OqfUy>
.
|
Fixed a bunch of tests and re-tested against the Demo org in AU. I also removed a whole bunch of console.log statements from the code. @philals would be awesome if you could pull the latest and re-test. |
Ok, so I've tested this on demo company NZ. The issues were due to I've updated the tests to make sure all the dependent I've also had positive feedback from a couple of users that there aren't any backwards compatibility issues here which is great. Back to you @philals. |
All green for me locally. |
This PR removes all usage of XML in the library, now only using application/json for GET/PUT/POST requests.
A number of changes were required to get this to work, including:
Date
(these were previouslyString
)As part of this PR I have also refactored the tests to be in separate files, as the
accountingtests.js
file was almost 4k lines.The tests are now driven by a file called
testrunner.js
which imports the other files as needed. Users can simply comment out the tests they don't want to be run and only the imported tests will execute.I have updated the extend.js function to be the latest from Backbone.js.
Lastly, I've added a new parameter to the testing_config.json called
selectedAppId
. This is used to select an app other than the default in the dropdown when getting an OAuth token for Public/Partner applications.The user must first browse to that screen in a proper browser, inspect the source code, and get the ID of the app they want to select and paste it into the config file.