-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compressing meteor project takes forever #66
Comments
I am also having this issue. "Compressing project..." for up to 10 minutes and pegging CPU at 100%. That has only been happening for about a week for me. |
Same thing. I think the problem is that the modulus CLI is compressing the node_modules folder for some reason?? Shouldn't this be done on the server being deployed to? |
Same for me.. takes about 15 minutes. Project compressed to 28.6 MB and it's not a large project but it does use a few npm modules.. Other projects take < 2mins.. |
As per XervoIO#66 I have removed the includeModules flag enforcement for Meteor projects. Currently it takes > 15mins to compress projects with npm dependencies and this should be done on the server we are deploying to. This problem will only get worse as the Meteor and npm ecosystem get closer. This can still be optionally set using the --include-modules commend.
Would be great to merge this - killing me that it takes to long to deploy and sure it's hurting other people's productivity too! |
Ah nice. |
The real solution to this is to have Modulus create a proper build image for meteor which will do the conversion at build time. I'll get that added to the new feature list. In the meantime, here's a stopgap: use Demeteorizer@2.3.1 then deploy the generated source.
The older version of demeteorizer attempts to get all of your dependencies into a generated package.json. This works most of the time but, because of the way Meteor manages packages, has a tendency to be unpredictable, inconsistent, and broken. That's where demeteorizer@3 comes in. It solves that by have Meteor include its dependencies. Moving this step to the build pipeline makes a lot of sense so we'll see about making that happen. The problem there is that takes control away from you as you no longer have control over how the build is done. This is an issue if you are using the meteorhacks npm package with compiled modules which won't work with I'll keep this thread updated as we work through this. |
Thanks. Also keep in mind that Meteor is going to have a more official support for NPM in Meteor 1.3 which will do away with having to use |
@fiveisprime |
Maybe the system tgz/gzip tools could be used, if available, for the compression part? For those experimenting with this option, it's kind of ridiculous how long this takes. |
Just for anyone who's wondering, it takes over an hour and a half to compress the build and upload a 110mb node_modules directory, in addition to our application code (which is a drop in that bucket). The compressed build was 55mb. So, be warned, if using the -m option. |
I just upgrade my project to 1.3 and the compressing takes forever now, which was not the case before I updated. Any updates on this issue, particularly related to deploying meteor 1.3 apps? |
@lytstephen I'm having the same problem. Also, uploading to Modulus fails. Have you been able to successful complete your modulus deployment (even though it takes forever)? |
I'm having the same issue and it's hit and miss on the deploy. Sometimes it works and sometimes it fails for random reasons. |
Please try using our new
|
Learned my lesson. Always having a staging environment (INCLUDING Modulus). Note: I'm using 1.3 as well. |
@IamCharlesHan & company - there is a new environment on Modulus.io called "Meteor" (you're probably using NodeJS). Switch to that then reset your server. Finally, redeploy. If you are having jquery warnings on your console remember to go to the root of your project and run |
@ajschmaltz That worked for me. Thank you. |
Actually no it didnt. It fails to deploy.
|
Sorry, wrong issue answer I'm also stuck in hell with this.
|
@IamCharlesHan - I was slightly frustrated and am by no means an expert, I was just relaying my experience and hoped it helped someone... BUT ... I forgot to mention I also upgraded to Meteor 1.3.1 based on something I read. I don't remember why & I don't know if that matters. I do know that I was having all the issues above and now everything runs smoothly for me. |
@ajschmaltz I think I'm in your shoes as well. I think that worked (for now)... I really appreciate it! Thank you. |
We've been having all kinds of problems as well after upgrading modulus cli versions. We rolled back to a previous version and things are working well now:
|
@BruceHubbard Are you on Meteor 1.3+ and do you build for mobile platforms? If so what's working for you now. I'm stuck ... |
We're not doing cordova or anything like that, just straight up Meteor web app. We are using 1.3 though. Downgrading the modulus cli seemed to do the trick for us. |
We are hitting this one, too. |
@csillag Try downgrading your modulus-cli version and see if that fixes it. It's not a perfect fix but it allowed us to deploy again. |
@BruceHubbard I already tried that, and it failed.
|
@csillag have you tried using our new meteor image, and updated CLI: You'll also want to change your runtime image to Meteor on our project's administration page. I also noticed this error in your logs |
I created the project yesterday, on the modulus web ui, using the meteor image.
I have tried 4.0.2 and 5.0.1, but not the unreleased 6.0.0. Now I tried that, too. With that, the results are different:
I only get these errors here, otherwise, the build runs successfully.
Isn't this the same thing as you said in your first sentence? ("using our new meteor image")
I could use a bit more detail here. What specifically is missing? The project is OK; I can successfully deploy it to (for example) Galaxy. |
Also, I always get this:
Why does it do this? I have a perfectly functional Meteor distribution on my path.. |
@csillag if you send an email to help@modulus.io I can look into your specific project. The first part of installing It's hard to say what's causing I searched around for people's solutions for the Now seeing the new log output you mentioned, |
I understand the problem now, but it's unclear how to solve it best. However, demeteorizer chokes on this file, because it tries to re-create the build environment somehow, and the symlink will miss its target.... |
I will probably get rid of this packaging trick, but than requires some work in other areas... |
OK, now I have a new error message (channeled to me from the Modulus build servers):
Usually, ENOSPC means out of disk space... but it must be something else now, right? |
I just totally dropped modulus and went with galaxy. |
Ditto, but with DigitalOcean. It's not as hard as I thought, and I have full control. |
@ajschmaltz & @twastvedt Thanks for the time you have spent with us. We hope to make things even better in the future and get the Meteor Beta to a better and stable state. Good luck & happy coding! |
@tzmanics I shouldn't carelessly speak, let me follow your kind gesture with a recommendation for others: Modulus is great. Deploying many projects in many environments is very well done, competitively priced and all in once place. I recommend it to all. Meteor's in house solution just obviously is going to handle bleeding edge cases with more stability. I do plan on switching back once things stabilize. That's the great thing about how portable this stuff is these days. |
Thank you @ajschmaltz we really do appreciate that & are working to get these issues resolved :) |
OK so now it's clear that I am hitting a separate problem, I will open a new issue about it. |
As an addition to @tzmanics' solution (ended up working for us, thank you!): After changing the runtime image to |
The solution given by @jackboberg here works but it did take us a little while to get there. In the end we reset the project, removed |
It seemed like I didn't have a choice but to move to stay with CLI 6.0 and update my DEV env to a Meteor image. I really didn't want to move to a Meteor image while it was being called Beta. But, here I am and I'll be moving to the Meteor image for prod on my next deployment 6/16/16. |
I havent found a solution for the [Error] There was a problem deploying your project. problem. I wanted it to run on the new Meteor beta container but i cant seem to make it work. Any tips? |
I was used to very fast deployments on modulus but lately my "modulus project deploy" stays in "Compressing project" state before uploading for soooo long. ( > 4minutes)
Am I the only one getting this ?
Meteor 1.1.6
Modulus 5.0.1
Project compressed about 52 MB (Maybe that's the root of the issue :) )
thanks !
The text was updated successfully, but these errors were encountered: