Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/update dependencies #130

Merged
merged 2 commits into from
Jul 28, 2016
Merged

Conversation

theworkflow
Copy link
Contributor

  • bump fstream-ignore
  • bump update-notifier

Removes node@v6 installation warning
Closes #120

@@ -80,7 +81,7 @@ modulus.runCommand = function (command, args, authRequired) {
modulus.io.print('Welcome to ' + 'Modulus'.magenta);

var diff = require('update-notifier')({
packagePath: path.resolve(__dirname, '..', 'package.json')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced path with json...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Via update-notifier's documentation.

@jackboberg
Copy link
Contributor

👍 assuming your tests all worked

@theworkflow
Copy link
Contributor Author

theworkflow commented Jul 27, 2016

Test cases

  • Deploy a project with a .modulusignore file (tests fstream-ignore)
  • **Run the CLI with older version of package.json (tests update-notifier)

** I'm not sure if the results that update-notifier gets are cached. It sometimes notified when the version of the CLI was outdated. I tested this also by npm i -g modulus@5.0.1, then ran the modulus command. I was not prompted that I was using an outdated version.

@theworkflow theworkflow force-pushed the enhancement/update-dependencies branch from 78b7b2c to b05015a Compare July 27, 2016 19:17
@musgravejw
Copy link

👍

@theworkflow theworkflow merged commit 4d78ffe into master Jul 28, 2016
@theworkflow theworkflow deleted the enhancement/update-dependencies branch July 28, 2016 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants