Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hi-ui/icons 中的package.json应该增加 "sideEffects": false，保证其他打包工具可以进行tree shaking #2502

Closed
lippzhang opened this issue May 31, 2023 · 0 comments · Fixed by #2535
Closed

hi-ui/icons 中的package.json应该增加 "sideEffects": false，保证其他打包工具可以进行tree shaking #2502

lippzhang opened this issue May 31, 2023 · 0 comments · Fixed by #2535
Labels
bug Something isn't working

Comments

@lippzhang
Copy link

No description provided.

@lippzhang lippzhang added the bug Something isn't working label May 31, 2023
zyprepare added a commit that referenced this issue Jul 13, 2023
@zyprepare
perf(icons): #2502
3aa4b94
@zyprepare zyprepare mentioned this issue Jul 13, 2023
Merged
solarjoker added a commit that referenced this issue Jul 13, 2023
@solarjoker
Merge pull request #2535 from XiaoMi/hotfix/icons-optimize
863a43c 
perf(icons): #2502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(icons): #2502 XiaoMi/hiui
1 participant
@lippzhang