Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: table level slow query #400

Merged
merged 61 commits into from
Oct 12, 2019
Merged

feat: table level slow query #400

merged 61 commits into from
Oct 12, 2019

Conversation

levy5307
Copy link
Contributor

@levy5307 levy5307 commented Sep 26, 2019

What problem does this PR solve?

add table level slow query which can be configured by app envs

What is changed and how it works?

use command

set_app_envs replica.slow_query_threshold {threshold_ms}

to set table level slow query threshold(threshold must be >= 20ms) use command.

set_app_envs replica.enable_slow_query_log true

to open table level slow query log.

Check List

Tests

  • Unit test
    yes

Code changes

  • Has interface methods change
    yes

Side effects

  • Breaking backward compatibility

Our slow query analysis engine may be unable to parse the new slow logs.

Related changes

  • Need to cherry-pick to the release branch
    yes
  • Need to update the documentation
    yes
  • Need to be included in the release note
    yes

@acelyc111 acelyc111 reopened this Oct 10, 2019
acelyc111
acelyc111 previously approved these changes Oct 11, 2019
@neverchanje
Copy link
Contributor

PR 的描述需要改,有配置更改的必须在 PR 的描述里面写清楚,避免服务升级的时候出错。

src/server/pegasus_server_impl.h Outdated Show resolved Hide resolved
src/server/pegasus_server_impl.cpp Show resolved Hide resolved
neverchanje
neverchanje previously approved these changes Oct 12, 2019
@neverchanje neverchanje merged commit 92a55b2 into apache:master Oct 12, 2019
@neverchanje neverchanje mentioned this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants