Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shell): add qps and p99 statistics while list_node #420

Merged
merged 5 commits into from
Nov 18, 2019

Conversation

hycdong
Copy link
Contributor

@hycdong hycdong commented Nov 14, 2019

What problem does this PR solve?

We used to get server basic qps and latency information by command server_stat. However, server_stat is hard to read, and some memory-related statistics have already be shown by command nodes -u. As a result, I add command nodes -q to show qps and latency information provided by server_stat.

What is changed and how it works?

Add command nodes -q to show server read, write qps and read, write latency.
The command sample is below:

>>> nodes -q
[details]
address   status    get_qps  get_p99(ms)  mget_qps  mget_p99(ms)  put_qps  put_p99(ms)  mput_qps  mput_p99(ms)
host1     ALIVE       23.86         0.13     86.63          0.44    42.57         3.27      0.00          0.00
host2     ALIVE       18.61         0.12     99.69          0.52     0.00         3.20      0.00          0.00
host3     ALIVE       21.88         0.16     58.71          0.59     0.00         3.54      0.00          0.00
host4     ALIVE       17.32         0.10     74.54          0.50    25.74         3.23      0.00          0.00
host5     ALIVE       21.08         0.11     99.95          0.52    27.51         0.92      0.00          0.00

[summary]
total_node_count    : 5
alive_node_count    : 5
unalive_node_count  : 0

Check List

Tests

  • Manual test

@neverchanje
Copy link
Contributor

This PR is great, but we should still consider some approach for node-level qps on falcon view, not simply on shell.

neverchanje
neverchanje previously approved these changes Nov 15, 2019
Copy link
Contributor

@foreverneverer foreverneverer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既然把qps信息加在了node下,那之前的server_stat的相关信息是不是可以删掉了,同时也规范一下server_stat的print格式?

@hycdong
Copy link
Contributor Author

hycdong commented Nov 15, 2019

既然把qps信息加在了node下,那之前的server_stat的相关信息是不是可以删掉了,同时也规范一下server_stat的print格式?

这个pr先添加nodes -q这个命令,server_stat后面的pr再处理,看是删除还是重构print的格式

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/shell pegasus shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants