This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
bugfix: fix bug of calculating shared log size #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengofsun
reviewed
Jul 16, 2018
|
|
||
| int64_t mutation_log::total_size_no_lock() const | ||
| { | ||
| return _log_files.size() > 0 ? _global_end_offset - _global_start_offset : 0; |
There was a problem hiding this comment.
用TODO说明下log_size如果为0，那么global_start_offset是无效的。
|
有想过又不想过，还是感觉有点为了修bug而修bug…… |
shengofsun
approved these changes
Jul 16, 2018
acelyc111
approved these changes
Jul 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #133