*: expose disk_file that was hidden under dsn_handle_t #172
Conversation
include/dsn/c/api_layer1.h
Outdated
| @@ -276,6 +276,11 @@ typedef struct | |||
| int size; | |||
| } dsn_file_buffer_t; | |||
|
|
|||
| namespace dsn { | |||
There was a problem hiding this comment.
如果可以的话，你看看能不能把file相关的接口都专门拿出来放到一个头文件里面去。
这样只移除一个dsn_handle_t, 又加个namespace，感觉和这个文件的整体风格很不搭
There was a problem hiding this comment.
这个可不可以之后再干，我感觉 disk engine 这个模块都可以放到 utility 下，跟 utility/filesystem.h 合到一起，就是需要整，我最近要专注搞 valgrind
There was a problem hiding this comment.
主要就是这个不太搭的修改放在这里会有些诡异，因为这个不完整的改动可能会一放就是很久……
专门搞valgrind没问题，集中只提valgrind相关的pr就好了。
另外disk_engine还是别放utility下了。utility/filesystem.h是对OS文件系统API的封装，而rdsn的disk engine是和task相关的异步接口，挪出去不合适。
| @@ -80,12 +80,11 @@ void nfs_service_impl::on_copy(const ::dsn::service::copy_request &request, | |||
| hfile = dsn_file_open(file_path.c_str(), O_RDONLY | O_BINARY, 0); | |||
| if (hfile) { | |||
|
|
|||
| file_handle_info_on_server *fh = new file_handle_info_on_server; | |||
| auto fh = std::make_shared<file_handle_info_on_server>(); | |||
There was a problem hiding this comment.
只有 close_file() 的时候会 delete，然而_handle_maps 在析构的时候可能不是所有的文件都 close 了，所以要么在 nfs_service_impl 析构的时候 for delete 一下，要么直接用 shared ptr
neverchanje
requested review from
shengofsun,
qinzuoyan,
acelyc111,
hycdong,
mentoswang,
vagetablechicken and
zhangyifan27
|
@shengofsun 按你要求改了，可以看下 |
include/dsn/tool-api/file_io.h
Outdated
| \param offset offset in the file to start reading | ||
| \param cb callback aio task to be executed on completion | ||
| */ | ||
| extern void dsn_file_read(disk_file *file, char *buffer, int count, uint64_t offset, aio_task *cb); |
There was a problem hiding this comment.
这个dsn_file_read、dsn_file_wrte和dsn_file_write_vector这三个c接口可以和async_calls.h中file namespace下的几个接口整合一下。这样我们就不用保留两套异步的文件接口了。
There was a problem hiding this comment.
这一改改的有点大，我怕扯到蛋...我尽量看看
|
另外催人给我过一下hpc_lock的那个review？ |
|
恩，明天我催下 |
|
@shengofsun 按你要求又改了，你看看是不是你想要的 |
This PR also fixes 2 memory leaks:
src/dist/nfs/nfs_server_impl.cpp: value of
nfs_service_impl::_handles_mapis a raw pointer but not deleted during destruction ofnfs_service_impl.src/core/tools/common/native_aio_provider.linux.cpp: there's a
std::threadwild pointer