This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
replica-server: support remote command useless-dir-reserve-seconds #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
previously approved these changes
Jan 10, 2019
acelyc111
reviewed
Jan 10, 2019
| "gc_disk_garbage_replica_interval_seconds", | ||
| [this](const std::vector<std::string> &args) { | ||
| std::string result("OK"); | ||
| if (args.size() <= 0) { |
| [this](const std::vector<std::string> &args) { | ||
| std::string result("OK"); | ||
| if (args.size() <= 0) { | ||
| result = "error(" + std::to_string(_gc_disk_error_replica_interval_seconds) + |
There was a problem hiding this comment.
这不是错误信息，这是返回现在的值，我改一下吧
| _gc_disk_garbage_replica_interval_seconds = | ||
| _options.gc_disk_garbage_replica_interval_seconds; | ||
| } else { | ||
| int v = atoi(args[0].c_str()); |
|
|
||
| _garbage_dir_reserve_seconds_command = dsn::command_manager::instance().register_app_command( | ||
| {"garbage-dir-reserve-seconds"}, | ||
| "garbage-dir-reserve-seconds [num | DEFAULT]", |
There was a problem hiding this comment.
改成useless-dir-reserve-seconds
acelyc111
approved these changes
Jan 10, 2019
qinzuoyan
changed the title
hycdong
approved these changes
Jan 10, 2019
vagetablechicken
pushed a commit
to vagetablechicken/rdsn
that referenced
this pull request
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to dynamically change
gc_disk_error_replica_interval_secondsandgc_disk_garbage_replica_interval_seconds.for the reason, please refer to: 垃圾文件夹管理