This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
replica-server: add counters of recent_read_fail_count and recent_wri… #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
added
type/enhancement
qinzuoyan
requested review from
shengofsun,
neverchanje,
acelyc111 and
hycdong
neverchanje
reviewed
Jan 17, 2019
src/dist/replication/lib/replica.h
Outdated
| @@ -160,7 +164,7 @@ class replica : public serverlet<replica>, public ref_counter, public replica_ba | |||
| private: | |||
| // common helpers | |||
| void init_state(); | |||
| void response_client_message(bool is_read, dsn::message_ex *request, error_code error); | |||
| void response_client(bool is_read, dsn::message_ex *request, error_code error); | |||
There was a problem hiding this comment.
定义两个函数 respond_client_for_read / respond_client_for_write 更直观，内部调用 respond_client
neverchanje
approved these changes
Jan 17, 2019
acelyc111
approved these changes
Jan 17, 2019
This was referenced Jan 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te_fail_count
refer to apache/incubator-pegasus#259