This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
add prometheus to thirdparty #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Jul 26, 2019
thirdparty/download-thirdparty.sh
Outdated
| @@ -244,6 +244,18 @@ check_and_download "${GFLAGS_PKG}"\ | |||
| "${GFLAGS_NAME}" | |||
| exit_if_fail $? | |||
|
|
|||
| # prometheus-cpp | |||
| if [ ! -d $TP_SRC/prometheus-cpp ]; then | |||
| git clone https://github.com/jupp0r/prometheus-cpp.git --recursive | |||
There was a problem hiding this comment.
用 0.7.0 有没有问题？我们的依赖包为了加速通常放在阿里云 oss，你应当这个也一样。没问题我就放上去。
There was a problem hiding this comment.
用release版本的话prometheus本身会缺少第三方库，并且无法用git submodule init/update获取，在build的时候会失败
There was a problem hiding this comment.
第三方库gtest可以禁掉，option(ENABLE_TESTING "Build tests" ON)。也不会为第三方跑测试，不用build。
civetweb就和Prometheus一样，单独下来吧
git clone master还是不能保证稳定性
vagetablechicken
previously approved these changes
Jul 30, 2019
acelyc111
reviewed
Jul 30, 2019
acelyc111
reviewed
Jul 30, 2019
vagetablechicken
approved these changes
Jul 30, 2019
acelyc111
approved these changes
Jul 30, 2019
neverchanje
added
area/installation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download and build prometheus to thirdparty
then prometheus can be used as a new way to report data