Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnings from objtool on new kernels #190

Closed
okt-sergeyn opened this issue Dec 1, 2023 · 1 comment
Closed

warnings from objtool on new kernels #190

okt-sergeyn opened this issue Dec 1, 2023 · 1 comment

Comments

@okt-sergeyn
Copy link
Contributor

There are warnings from objtool when building onload modules on some kernels:

warning: objtool: __ci_fail() falls through to next function ci_backtrace()
warning: objtool: my_stop_fn() falls through to next function ci_log_buffer_till_fail()

and

warning: objtool: ci_tcp_tmpl_handle_nic_reset+0x4ae: __ci_sys_fail() is missing a __noreturn annotation
warning: objtool: ci_netif_state_init+0x348: __oo_shmbuf_ptr2off() is missing a __noreturn annotation
warning: objtool: ci_tcp_connect_lo_samestack+0x1a3f: __ci_sys_fail() is missing a __noreturn annotation

I see it on Fedora 38 with kernel 6.5.6-200.fc38.x86_64 on onload master 106c23f

Although objtool has already been turned off in onload - https://github.com/Xilinx-CNS/onload/blob/master/mk/linux_kbuild.mk#L100
it still works on the mentioned kernel (I suppose CONFIG_X86_KERNEL_IBT=y config option is related).

The warnings seem sensible, I'll prepare PR.
okt-sergeyn added a commit to okt-sergeyn/onload that referenced this issue Dec 1, 2023
@okt-sergeyn
issue Xilinx-CNS#190: fix "falls through to next function" warning
af6a8b9 
Despite of 'objtool' is disabled for Onload, it still may run
during the build on some kernels and generate warnings like:
"<func1> falls through to next function <func2>".
Mark related functions __ci_fail() and my_stop_fn() with
STACK_FRAME_NON_STANDARD macro to tell objtool to ignore them.

Signed-off-by: Sergey Nikitin <sergey.nikitin@oktet.tech>
okt-sergeyn added a commit to okt-sergeyn/onload that referenced this issue Dec 1, 2023
@okt-sergeyn
issue Xilinx-CNS#190: add missed noreturn attribute
9f936e4 
Mark __ci_sys_fail() as noreturn to stop objtool generating
"__ci_sys_fail() is missing a __noreturn annotation" warning.

Signed-off-by: Sergey Nikitin <sergey.nikitin@oktet.tech>
okt-sergeyn added a commit to okt-sergeyn/onload that referenced this issue Dec 1, 2023
@okt-sergeyn
issue Xilinx-CNS#190: fix objtool warning by removing useless function
01516d2 
__oo_shmbuf_ptr2off() triggers objtool warning:
"__oo_shmbuf_ptr2off() is missing a __noreturn annotation".

The function's only purpose now is to crash with ci_assert(0).
There's no reason to keep it.
The patch moves the assertion to the caller (oo_shmbuf_ptr2off)
and removes __oo_shmbuf_ptr2off().

Signed-off-by: Sergey Nikitin <sergey.nikitin@oktet.tech>
@okt-sergeyn okt-sergeyn mentioned this issue Dec 1, 2023
Merged
@ivatet-amd
Copy link
Contributor

Closing as #191 is merged, thanks!

cns-ci-onload-xilinx pushed a commit that referenced this issue Dec 6, 2023
@okt-sergeyn @ivatet-amd
issue #190: fix "falls through to next function" warning
401a5ca 
Despite of 'objtool' is disabled for Onload, it still may run
during the build on some kernels and generate warnings like:
"<func1> falls through to next function <func2>".
Mark related functions __ci_fail() and my_stop_fn() with
STACK_FRAME_NON_STANDARD macro to tell objtool to ignore them.

Signed-off-by: Sergey Nikitin <sergey.nikitin@oktet.tech>
(cherry picked from commit af6a8b9)
cns-ci-onload-xilinx pushed a commit that referenced this issue Dec 6, 2023
@okt-sergeyn @ivatet-amd
issue #190: add missed noreturn attribute
138a5d4 
Mark __ci_sys_fail() as noreturn to stop objtool generating
"__ci_sys_fail() is missing a __noreturn annotation" warning.

Signed-off-by: Sergey Nikitin <sergey.nikitin@oktet.tech>
(cherry picked from commit 9f936e4)
cns-ci-onload-xilinx pushed a commit that referenced this issue Dec 6, 2023
@okt-sergeyn @ivatet-amd
issue #190: fix objtool warning by removing useless function
26cdf51 
__oo_shmbuf_ptr2off() triggers objtool warning:
"__oo_shmbuf_ptr2off() is missing a __noreturn annotation".

The function's only purpose now is to crash with ci_assert(0).
There's no reason to keep it.
The patch moves the assertion to the caller (oo_shmbuf_ptr2off)
and removes __oo_shmbuf_ptr2off().

Signed-off-by: Sergey Nikitin <sergey.nikitin@oktet.tech>
(cherry picked from commit 01516d2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivatet-amd @okt-sergeyn