CR-1140963: Blank lines at start AIE Trace txt file, leads to problem in vitis analyzer validation #7059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
|
Build Failed! :( |
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
|
Build Failed! :( |
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
|
Build Failed! :( |
|
Please re-test |
|
retest this please. |
1 similar comment
|
retest this please. |
|
Build Failed! :( |
|
retest this please. |
|
Build Failed! :( |
|
retest this please. |
|
Build Failed! :( |
|
retest this please. |
|
Build Passed! |
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
|
Build Passed! |
jvillarre
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Schumacher schuey@xilinx.com
Problem solved by the commit
Fixed bug where in certain cases, blank lines would be written to the top of AIE trace files.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Blank lines were written to top of file in beamformer with compile-time trace.
How problem was solved, alternative solutions (if any) and why they were rejected
Only write a blank line in deconstructor of trace writer.
Risks (if any) associated the changes in the commit
The fout ofstream may be closed before the deconstructor.
What has been tested and how, request additional testing if necessary
Used design from CR as well as other AIE trace tests.
Documentation impact (if any)
N/A