CR1139733 : Fix for wrong generation of warning of deadlock in HW Emu AIE status #7064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for deadlock even if the design is not deadlocked. This causes wrong generation of warnings for deadlock. To fix this, deadlock warnings are disabled in HW Emu Signed-off-by: IshitaGhosh <ighosh.account@gmail.com>
|
Build Passed! |
jvillarre
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: IshitaGhosh ighosh.account@gmail.com
Problem solved by the commit
In HW Emu, AIE status wrongly generates warning for deadlock.
How problem was solved, alternative solutions (if any) and why they were rejected
In HW Emu as simulation is slower, a design may hit realtime threshold for deadlock even if the design is not deadlocked. This causes wrong generation of warnings for deadlock. To fix this, deadlock warnings are disabled in HW Emu.
Another solution could be to read and use timer values to determine whether the design is actually deadlocked. But this would need extensive changes, may be even in driver. So, this can be looked into in later releases.
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Reported design.
Documentation impact (if any)
Generation of warning message for potential deadlock is now disabled in HW Emu AIE Status. This change in behavior needs to be documented.