-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CR-1149626 Backport SC warning (#7304) #7310
CR-1149626 Backport SC warning (#7304) #7310
Conversation
* CR-1149626 Add warning for SC mismatch Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com> * CR-1149626 Add default option to prevent failures due to warning queries Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com> * CR-1149626 Update error message to remove 0.0.0 and replace with NA Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com> Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com> (cherry picked from commit a722d40)
Build Passed! |
@dbenusov-xilinx I suppose the backport was clean, thus approved. |
We are seeing this with all our VCK5000 boards on RHEL 8.8 running a slightly patched XRT 2.14 (https://github.com/pc2/XRT/commits/2022.2_RHEL8.8). However, xbmgmt can properly report SC versions installed on the board and on the system (I would assume the latter one is the target SC version?):
Indeed, the sdm hwmon reports 0.0.0 as target_msp_ver:
|
The change causes the following warning for all of our VCK5000 boards for no good reason: *********************************************************** * WARNING WARNING WARNING * * SC version data missing. Expected: N/A Current: 4.4.35 * *********************************************************** See: Xilinx#7310 (comment) This reverts commit 523e164.
Signed-off-by: Daniel Benusovich dbenusov@xilinx.com
Signed-off-by: Daniel Benusovich dbenusov@xilinx.com
Signed-off-by: Daniel Benusovich dbenusov@xilinx.com
Signed-off-by: Daniel Benusovich dbenusov@xilinx.com
(cherry picked from commit a722d40)
Backport of #7304
https://jira.xilinx.com/browse/CR-1147768
There is not a CLEAN way that customers can flash a shell on a Versal platform without warnings or errors. After flashing the shell the users are expected to flash the device again to update the SC, but, we make no mention of that requirement in the tooling. As a result, users are confused when their shells fail due to interacting the with incorrect SC.
To deal with this problem we would like to add three features:
xbmgmt program -d <BDF> -b
to output a warning stating to program again to change the SC (Versal devices only)xbmgmt examine -b <BDF> -r platform
warning if the SC version does not match the expected SC version from the shellThere will be 2 PRs for this change.
The first deals with the flashing behavior (Already done)
The second deals with the additional warning message (This PR)
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Users do not see if their SC version is not aligned with their installed shell. This can cause problems when attempting to run programs.
How problem was solved, alternative solutions (if any) and why they were rejected
Added a warning message after comparing the expected and the target SC version.
Risks (if any) associated the changes in the commit
If there is a fault with the hardware and neither sysfs node appears the following message will be displayed:
Missing sysfs nodes will display N/A
What has been tested and how, request additional testing if necessary
Ubuntu 20.04 VCK5000
Bad SC Version warning
Documentation impact (if any)
Platform team needs to notate what the warnings mean.