XDP User Plugin Format changes #7555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
|
Build Passed! |
pgschuey
approved these changes
May 17, 2023
Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
hackwa
reviewed
May 17, 2023
| extern "C" | ||
| XDP_EXPORT | ||
| void user_event_end_cb(unsigned int functionID) ; | ||
| extern "C" XDP_EXPORT void user_event_end_cb(unsigned int functionID); |
There was a problem hiding this comment.
Think It's preferable and to put exports and externs on separate lines.
There was a problem hiding this comment.
Yes, XRT code also uses separate lines.
| VTFEvent* event = new UserRange( | ||
| start, static_cast<double>(timestamp), | ||
| false, // isStart | ||
| 0, 0); |
There was a problem hiding this comment.
This makes sense. However some minor issues:
- We use 2 spaces for indentation. 4 isn't consistent with that.
- Also, I'd propose the end bracket to be on new line for even more clarity.
VTFEvent* event = new UserRange (
start, static_cast(timestamp),
false, // isStart
0, 0
);
| db->getStaticInfo().addOpenedFile(w->getcurrentFileName(), "VP_TRACE"); | ||
| } | ||
| db->unregisterPlugin(this) ; | ||
| db->unregisterPlugin(this); | ||
| } | ||
| UserEventsPlugin::live = false; | ||
| } | ||
|
|
||
| void UserEventsPlugin::writeAll(bool openNewFiles) |
There was a problem hiding this comment.
XRT code also puts class types on a separate line like:
void UserEventsPlugin::
writeAll(bool openNewFiles)
I'd propose we follow that.
|
|
||
| const char* labelStr = (label == nullptr) ? "" : label ; | ||
| const char* tooltipStr = (tooltip == nullptr) ? "" : tooltip ; |
There was a problem hiding this comment.
I think it's okay to add extra spaces for sake of readability
|
Build Passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Format changes for User Plugin