Multislot fixes for multiple PS kernel load #7558
Conversation
Signed-off-by: Saif <saifuddi@amd.com>
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
saifuddin-xilinx
changed the title
|
Build failed :( |
saifuddin-xilinx
added
the
Please do not Review
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
|
Build failed :( |
|
retest this please. |
|
Build failed :( |
|
retest this please. |
|
Build failed :( |
|
retest this please |
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
|
Build failed :( |
|
Build failed :( |
|
retest this please. |
|
Build failed :( |
|
retest this please. |
|
Build failed :( |
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
saifuddin-xilinx
removed
the
Please do not Review
|
Build failed :( |
|
retest this please. |
|
Build failed :( |
|
retest this please. |
|
Build failed :( |
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
|
Build Passed! |
|
|
||
| for (i = 0; i < ec->ec_num_xgq_ips; i++) { | ||
| struct ert_ctrl_xgq_cu *xgq_ips = &ec->ec_xgq_ips[i]; | ||
| int xgq_id = xocl_get_xgq_id(xgq_handle); |
There was a problem hiding this comment.
xocl_get_xgq_id() cound return -EINVAL. But xgq_id here is not checking that error.
There was a problem hiding this comment.
Fixed. Please reiew.
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
| if (xgq_id == -EINVAL) | ||
| return; |
There was a problem hiding this comment.
If xgq_id is -EINVAL here, it is a BUG_ON(). Not silently return.
There was a problem hiding this comment.
Sure. Updated. Thanks
|
Build failed :( |
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
|
Build failed :( |
|
retest this please |
|
Build failed :( |
|
retest this please. |
|
Build Passed! |
Problem solved by the commit
-- There is a issue for XGQs assign/reassign for multislot case.
-- Current implementation delete all the XGQs together while unregistering the CUs
-- For multislot case it should be done by slot wise.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)