New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for CR:1163285: change reserved_row_start and reserved_num_rows to mem_row_start and mem_num_rows in aie_control_config.json #7565

Merged

chvamshi-xilinx merged 1 commit into Xilinx:master from saumyag-xilinx:aie-control-config

May 29, 2023

Collaborator

saumyag-xilinx commented May 22, 2023 •

edited

Loading

Problem solved by the commit

https://jira.xilinx.com/browse/CR-1163285
XRT is now supporting old and new property i.e reserved_row_start , reserved_num_rows as well as mem_row_start and mem_num_rows in driver_config section aie_metadata. Once the aie compiler is updated, we can remove the old property ie. reserved_row_start and reserved_num_rows.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

NA

How problem was solved, alternative solutions (if any) and why they were rejected

Risks (if any) associated the changes in the commit

NA

What has been tested and how, request additional testing if necessary

Verified application on aie1 and aie2 with updated xclbins

Documentation impact (if any)

NA


          updating XRT as per changed metadata field

60adffd

Signed-off-by: saumya garg <saumyag@xilinx.com>

saumyag-xilinx requested review from larry9523, chvamshi-xilinx and stsoe as code owners

May 22, 2023 12:30

saumyag-xilinx changed the title ~~updating XRT as per upcoming modified aie_metadata field~~ Fix for CR:1163285: change reserved_row_start and reserved_num_rows to mem_tile_row_start and mem_tile_num_rows in aie_control_config.json

saumyag-xilinx changed the title ~~Fix for CR:1163285: change reserved_row_start and reserved_num_rows to mem_tile_row_start and mem_tile_num_rows in aie_control_config.json~~ Fix for CR:1163285: change reserved_row_start and reserved_num_rows to mem_row_start and mem_num_rows in aie_control_config.json

Collaborator

gbuildx commented May 22, 2023

Build Passed!

chvamshi-xilinx approved these changes

View reviewed changes

Collaborator

chvamshi-xilinx left a comment

Looks good, but, we are parsing json file in multiple places. Better to consolidate them in a single place if possible in your upcoming PRs..

chvamshi-xilinx approved these changes

•

View reviewed changes

chvamshi-xilinx approved these changes

View reviewed changes

Collaborator

chvamshi-xilinx left a comment

Looks good, but, we are parsing json file in multiple places. Better to consolidate them in a single place if possible in your upcoming PRs..

chvamshi-xilinx approved these changes

View reviewed changes

Collaborator

chvamshi-xilinx left a comment

Looks good, but, we are parsing json file in multiple places. Better to consolidate them in a single place if possible in your upcoming PRs..

chvamshi-xilinx approved these changes

View reviewed changes

Collaborator

chvamshi-xilinx left a comment

Looks good, but, we are parsing json file in multiple places. Better to consolidate them in a single place if possible in your upcoming PRs..

chvamshi-xilinx approved these changes

View reviewed changes

Collaborator

chvamshi-xilinx left a comment

Looks good, but, we are parsing json file in multiple places. Better to consolidate them in a single place if possible in your upcoming PRs..

chvamshi-xilinx merged commit 89dc272 into Xilinx:master

saumyag-xilinx deleted the aie-control-config branch

February 6, 2024 08:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet