Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VITIS-9144 xbutil report for AIE column topology #7600

Closed
wants to merge 9 commits into from
Closed

VITIS-9144 xbutil report for AIE column topology #7600

wants to merge 9 commits into from

Conversation

dbenusov
Copy link
Contributor

@dbenusov dbenusov commented Jun 23, 2023 •
edited
Loading

Problem solved by the commit

https://jira.xilinx.com/browse/VITIS-9144

Need to support displaying AIE partition information to the user

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

New feature!

How problem was solved, alternative solutions (if any) and why they were rejected

Generate a report based on the AIE partition information returned from the driver. These are the changes only for xbutil, the shim changes must be completed in the appropriate repository.
If the --verbose option is specified an additional AIE column report will be generated. This is a second view of the data that is more useful for DSV folks.
The output json is the same regardless of the --verbose flag.

Risks (if any) associated the changes in the commit

New feature, no risks!

What has been tested and how, request additional testing if necessary

Ubuntu 20.04 with fake data
No verbose

---------------------------------------------------
[0000:17:00.1] : xilinx_vck5000_gen4x8_qdma_base_2
---------------------------------------------------
AIE Partitions
  Partition Index: 0
    Columns: [0, 1]
    HW Contexts:
      Slot ID  Xclbin UUID                           Usage Count  Migration Count  Device BO Sync Count
      ---------------------------------------------------------------------------------------------------
      0        2E98AE1C-7416-5E1D-E571-D7878E29587a  0            0                0
      1        2E98AE1C-7416-5E1D-E571-D7878E29587b  0            0                0
      2        2E98AE1C-7416-5E1D-E571-D7878E29587c  0            0                0

  Partition Index: 1
    Columns: [2]
    HW Contexts:
      Slot ID  Xclbin UUID                           Usage Count  Migration Count  Device BO Sync Count
      ---------------------------------------------------------------------------------------------------
      3        2E98AE1C-7416-5E1D-E571-D7878E29587d  0            0                0

  Partition Index: 2
    Columns: [3, 4]
    HW Contexts:
      Slot ID  Xclbin UUID                           Usage Count  Migration Count  Device BO Sync Count
      ---------------------------------------------------------------------------------------------------
      4        2E98AE1C-7416-5E1D-E571-D7878E29587e  0            0                0

With verbose

---------------------------------------------------
[0000:17:00.1] : xilinx_vck5000_gen4x8_qdma_base_2
---------------------------------------------------
AIE Partitions
  Partition Index: 0
    Columns: [0, 1]
    HW Contexts:
      Slot ID  Xclbin UUID                           Usage Count  Migration Count  Device BO Sync Count
      ---------------------------------------------------------------------------------------------------
      0        2E98AE1C-7416-5E1D-E571-D7878E29587a  0            0                0
      1        2E98AE1C-7416-5E1D-E571-D7878E29587b  0            0                0
      2        2E98AE1C-7416-5E1D-E571-D7878E29587c  0            0                0

  Partition Index: 1
    Columns: [2]
    HW Contexts:
      Slot ID  Xclbin UUID                           Usage Count  Migration Count  Device BO Sync Count
      ---------------------------------------------------------------------------------------------------
      3        2E98AE1C-7416-5E1D-E571-D7878E29587d  0            0                0

  Partition Index: 2
    Columns: [3, 4]
    HW Contexts:
      Slot ID  Xclbin UUID                           Usage Count  Migration Count  Device BO Sync Count
      ---------------------------------------------------------------------------------------------------
      4        2E98AE1C-7416-5E1D-E571-D7878E29587e  0            0                0

AIE Columns
  Column  HW Context Slot
  -------------------------
  0       [0, 1, 2]
  1       [0, 1, 2]
  2       [3]
  3       [4]
  4       [4]

JSON

{
    "schema_version": {
        "schema": "JSON",
        "creation_date": "Fri Jun 23 00:23:40 2023 GMT"
    },
    "devices": [
        {
            "interface_type": "pcie",
            "device_id": "0000:17:00.1",
            "device_status": "HEALTHY",
            "aie_partitions": [
                {
                    "start_col": "0",
                    "num_cols": "2",
                    "partition_index": "0",
                    "hw_contexts": [
                        {
                            "xclbin_uuid": "2E98AE1C-7416-5E1D-E571-D7878E29587a",
                            "slot_id": "0",
                            "usage_count": "0",
                            "migration_count": "0",
                            "device_bo_sync_count": "0"
                        },
                        {
                            "xclbin_uuid": "2E98AE1C-7416-5E1D-E571-D7878E29587b",
                            "slot_id": "1",
                            "usage_count": "0",
                            "migration_count": "0",
                            "device_bo_sync_count": "0"
                        },
                        {
                            "xclbin_uuid": "2E98AE1C-7416-5E1D-E571-D7878E29587c",
                            "slot_id": "2",
                            "usage_count": "0",
                            "migration_count": "0",
                            "device_bo_sync_count": "0"
                        }
                    ]
                },
                {
                    "start_col": "2",
                    "num_cols": "1",
                    "partition_index": "1",
                    "hw_contexts": [
                        {
                            "xclbin_uuid": "2E98AE1C-7416-5E1D-E571-D7878E29587d",
                            "slot_id": "3",
                            "usage_count": "0",
                            "migration_count": "0",
                            "device_bo_sync_count": "0"
                        }
                    ]
                },
                {
                    "start_col": "3",
                    "num_cols": "2",
                    "partition_index": "2",
                    "hw_contexts": [
                        {
                            "xclbin_uuid": "2E98AE1C-7416-5E1D-E571-D7878E29587e",
                            "slot_id": "4",
                            "usage_count": "0",
                            "migration_count": "0",
                            "device_bo_sync_count": "0"
                        }
                    ]
                }
            ]
        }
    ]
}

Documentation impact (if any)

None

@dbenusov
VITIS-9104 Add AIE partition report framework
554e21c 
Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com>
@dbenusov
VITIS-9104 Convert aie partition query to contain default value
02a927d 
Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com>
@dbenusov
VITIS-9104 Improve column display
9625c7a 
Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com>
@dbenusov
VITIS-9144 Add partition index to report output. Add partition index …
8503119 
…to output json

Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com>
@dbenusov
VITIS-9144 Add AIE column output for verbose
69181b9 
Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com>
@dbenusov dbenusov requested a review from larry9523 June 23, 2023 00:18
@gbuildx
Copy link
Collaborator

gbuildx commented Jun 23, 2023

Build failed :(

@dbenusov
VITIS-9144 Add reference symbol to for loops
c2d592d 
Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com>
@gbuildx
Copy link
Collaborator

gbuildx commented Jun 23, 2023

Build failed :(

@dbenusov
VITIS-9144 Add description to ptree
6c1d94f 
Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com>
@gbuildx
Copy link
Collaborator

gbuildx commented Jun 23, 2023

Build failed :(

@dayeh-xilinx
Copy link

retest this please.

1 similar comment
@dayeh-xilinx
Copy link

retest this please.

@gbuildx
Copy link
Collaborator

gbuildx commented Jun 26, 2023

Build failed :(

@dayeh-xilinx
Copy link

retest this please.

@sabarinaxil
Copy link

retest this please

@sabarinaxil sabarinaxil reopened this Jun 26, 2023
@sabarinaxil
Copy link

retest this please

1 similar comment
@sabarinaxil
Copy link

retest this please

@gbuildx
Copy link
Collaborator

gbuildx commented Jun 26, 2023

Build failed :(

@dbenusov
VITIS-9144 Comment out unused variable
4895d71 
Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com>
@gbuildx
Copy link
Collaborator

gbuildx commented Jun 27, 2023

Build Passed!

@dbenusov dbenusov marked this pull request as ready for review June 27, 2023 17:20
@dbenusov
VITIS-9144 remove aie-partitions from xrt_device query
038284f 
Signed-off-by: Daniel Benusovich <dbenusov@xilinx.com>
@dbenusov dbenusov requested a review from stsoe June 27, 2023 23:12
@dbenusov dbenusov closed this Jun 27, 2023
@gbuildx
Copy link
Collaborator

gbuildx commented Jun 28, 2023

Build Passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larry9523 larry9523 Awaiting requested review from larry9523

@vboggara-xilinx vboggara-xilinx Awaiting requested review from vboggara-xilinx

@rozumx rozumx Awaiting requested review from rozumx rozumx is a code owner

@uday610 uday610 Awaiting requested review from uday610

@chvamshi-xilinx chvamshi-xilinx Awaiting requested review from chvamshi-xilinx chvamshi-xilinx is a code owner

@stsoe stsoe Awaiting requested review from stsoe stsoe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dbenusov @gbuildx @dayeh-xilinx @sabarinaxil @stsoe